Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.23 blog post: Dual-stack IPv4/IPv6 Networking Reaches GA #30538

Merged
merged 1 commit into from
Dec 8, 2021
Merged

v1.23 blog post: Dual-stack IPv4/IPv6 Networking Reaches GA #30538

merged 1 commit into from
Dec 8, 2021

Conversation

bridgetkromhout
Copy link
Member

@bridgetkromhout bridgetkromhout commented Nov 17, 2021 •
edited
Loading

This is a blog post on behalf of SIG-Network for the v1.23 release, on the topic Dual-stack IPv4/IPv6 Networking (tracking issue, supporting KEP).

Next Steps:

  • Determine blog release date; adjust this PR as needed (set date per @karenhchu)
  • SIG-Docs review
  • SIG-Network tech review

Handy preview link: https://deploy-preview-30538--kubernetes-io-main-staging.netlify.app/blog/2021/12/07/dual-stack-networking-ga/

Signed-off-by: Bridget Kromhout bridget@kromhout.org

hold
/cc @karenhchu @lachie83 @reylejano @khenidak @aojea @thockin @dcbw @caseydavenport

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 17, 2021
@netlify
Copy link

netlify bot commented Nov 17, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: cd511ef

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61aa6af67448e80007f0f20f

😎 Browse the preview: https://deploy-preview-30538--kubernetes-io-main-staging.netlify.app

@mehabhalodiya
Copy link
Contributor

/assign @nate-double-u

@aojea
Copy link
Member

aojea commented Nov 18, 2021

/assign @sftim
we need the other Tim too :)

sftim
sftim reviewed Nov 18, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Here's some feedback - hope it's useful even as this is still WIP.

content/en/blog/_posts/2021-12-07-dual-stack-networking-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2021-12-07-dual-stack-networking-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2021-12-07-dual-stack-networking-ga.md Outdated Show resolved Hide resolved
@unixfox unixfox mentioned this pull request Nov 22, 2021
Open
@bridgetkromhout bridgetkromhout changed the title [WIP] v1.23 blog post: Dual-stack IPv4/IPv6 Networking Reaches GA v1.23 blog post: Dual-stack IPv4/IPv6 Networking Reaches GA Nov 29, 2021
@bridgetkromhout
Copy link
Member Author

/retitle v1.23 blog post: Dual-stack IPv4/IPv6 Networking Reaches GA

1 similar comment
@bridgetkromhout
Copy link
Member Author

/retitle v1.23 blog post: Dual-stack IPv4/IPv6 Networking Reaches GA

@bridgetkromhout bridgetkromhout changed the title v1.23 blog post: Dual-stack IPv4/IPv6 Networking Reaches GA WIP v1.23 blog post: Dual-stack IPv4/IPv6 Networking Reaches GA Nov 29, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7327a030fea0864e31c33dde70521f91787061f4

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2021
@bridgetkromhout
Copy link
Member Author

We may have further sig-network edits coming from @aojea, but in general I think this is ready for sig-docs comments.

@aojea
Copy link
Member

aojea commented Dec 1, 2021

We may have further sig-network edits coming from @aojea, but in general I think this is ready for sig-docs comments.

(i do believe we need to expand on the tech docs. but that is a battle for another day).

lgtm

Thanks

nate-double-u
nate-double-u reviewed Dec 1, 2021
View reviewed changes
Copy link
Contributor

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bridgetkromhout!

I've made a couple suggestions inline:

content/en/blog/_posts/2021-12-08-dual-stack-networking-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2021-12-08-dual-stack-networking-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2021-12-08-dual-stack-networking-ga.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2021
@nate-double-u
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c4428ee3c17d369a6706d91657419f9a836ded38

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2021
@bridgetkromhout @sftim @nate-double-u
Adding blog post for dual-stack GA
cd511ef 
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Co-authored-by: Nate W. <4453979+nate-double-u@users.noreply.github.com>
@jimangel
Copy link
Member

jimangel commented Dec 6, 2021

/milestone 1.23

@k8s-ci-robot k8s-ci-robot added this to the 1.23 milestone Dec 6, 2021
@karenhchu
Copy link
Contributor

/lgtm

@sftim
Copy link
Contributor

sftim commented Dec 8, 2021

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Dec 8, 2021
@sftim
Copy link
Contributor

sftim commented Dec 8, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4f90920 into kubernetes:main Dec 8, 2021
This was referenced Mar 29, 2022
Closed
Open
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u nate-double-u left review comments

@aojea aojea aojea left review comments

@khenidak khenidak khenidak left review comments

@sftim sftim sftim left review comments

@reylejano reylejano reylejano left review comments

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@dcbw dcbw Awaiting requested review from dcbw

@karenhchu karenhchu Awaiting requested review from karenhchu

@lachie83 lachie83 Awaiting requested review from lachie83

@thockin thockin Awaiting requested review from thockin

Assignees

@nate-double-u nate-double-u

@khenidak khenidak

@karenhchu karenhchu

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.23
Development

Successfully merging this pull request may close these issues.