Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2400: Alpha node support for swap memory #28838

Merged
merged 1 commit into from
Jul 21, 2021
Merged

KEP-2400: Alpha node support for swap memory #28838

merged 1 commit into from
Jul 21, 2021

Conversation

ehashman
Copy link
Member

@ehashman ehashman commented Jul 7, 2021 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added this to the 1.22 milestone Jul 7, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 7, 2021
@netlify
Copy link

netlify bot commented Jul 7, 2021 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 429638b

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60f71393d33166000724ca9c

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2021
@ehashman ehashman mentioned this pull request Jul 7, 2021
Open
60 tasks
@sftim
Copy link
Contributor

sftim commented Jul 7, 2021

A question about the feature gate name. Is it NodeMemorySwap or NodeSwapEnabled or both?

We usually don't put “Enable” or “Enabled” in feature gate names, so when I saw NodeSwapEnabled I was surprised. Typically you can take a feature gate name and use it to fill in the phrase “If you set this particular feature flag to true, it means that you enable thing in your cluster”.

@sftim
Copy link
Contributor

sftim commented Jul 7, 2021

/sig node
/milestone 1.22

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jul 7, 2021
@ehashman
Copy link
Member Author

ehashman commented Jul 7, 2021

kubernetes/kubernetes@0dd4ce4

It's NodeSwapEnabled. That missed all of KEP review, PRR, and PR review. It'll be non-trivial to change the name at this point.

@ehashman ehashman mentioned this pull request Jul 7, 2021
Merged
@sftim
Copy link
Contributor

sftim commented Jul 8, 2021

A nice-to-have PR to replace the feature gate name: kubernetes/kubernetes#103553

@PI-Victor
Copy link
Member

/assign @carlisia

@ehashman
Copy link
Member Author

lol bot no!

/reopen

@k8s-ci-robot
Copy link
Contributor

@ehashman: Reopened this PR.

In response to this:

lol bot no!

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Jul 10, 2021
@llhuii
Copy link
Contributor

llhuii commented Jul 14, 2021

kubernetes/kubernetes@0dd4ce4

It's NodeSwapEnabled. That missed all of KEP review, PRR, and PR review. It'll be non-trivial to change the name at this point.

It's still NodeSwapEnabled in KEP-2400, would you mind updating it?

@ehashman
Copy link
Member Author

@llhuii there's an open PR but it hasn't been approved: kubernetes/enhancements#2815

@llhuii
Copy link
Contributor

llhuii commented Jul 15, 2021

@ehashman got it, sorry to miss that.

@PI-Victor
Copy link
Member

Hello @ehashman 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 20th of July, 11:59 PM PDT. Thank you!

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2021
@ehashman ehashman changed the title [WIP] Placeholder PR: KEP-2400 Swap docs KEP-2400: Alpha node support for swap memory Jul 20, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2021
tengqm
tengqm reviewed Jul 20, 2021
View reviewed changes
content/en/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/en/docs/concepts/architecture/nodes.md Outdated Show resolved Hide resolved
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Jul 20, 2021

LGTM

I think we want this to have tech review from SIG Node / someone who's confident they can provide accurate feedback.

@ehashman
Copy link
Member Author

/assign @mrunalp
SIG Node technical reviewer

@mrunalp
Copy link
Contributor

mrunalp commented Jul 21, 2021

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 094f17d356706a6eabd5dc88b01ac6e3f9fc9545

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2021
@tengqm
Copy link
Contributor

tengqm commented Jul 21, 2021

This one is good to go.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit 98150e6 into kubernetes:dev-1.22 Jul 21, 2021
@ichbinblau ichbinblau mentioned this pull request Sep 27, 2021
Merged
@iholder101 iholder101 mentioned this pull request Jul 19, 2023
Closed
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

Assignees

@carlisia carlisia

@mrunalp mrunalp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
8 participants
@ehashman @sftim @PI-Victor @k8s-ci-robot @llhuii @mrunalp @tengqm @carlisia