Reimplement announcements #21586
Merged
Reimplement announcements #21586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
sig/docs
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 963a32f https://deploy-preview-21586--kubernetes-io-master-staging.netlify.app |
celestehorgan
commented
Jun 8, 2020
k8s-ci-robot
added
the
do-not-merge/hold
Signed-off-by: Celeste Horgan <celeste@cncf.io> Address deprecation-warning styling Signed-off-by: Celeste Horgan <celeste@cncf.io> Use partial only Signed-off-by: Celeste Horgan <celeste@cncf.io> Refine Signed-off-by: Celeste Horgan <celeste@cncf.io>
Signed-off-by: Celeste Horgan <celeste@cncf.io>
celestehorgan
force-pushed
the
reimplement-announcements
branch
from
b28d370
to
2579f26
Compare
celestehorgan
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
@celestehorgan Thank you so much for this, it looks ✨ ! |
Co-authored-by: Celeste Horgan <celeste@cncf.io>
|
Let's see if I can remember the Prow command for merge methods... /tide merge-method-squash |
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21496.
This PR improves the implementation of announcements by moving announcement strings into
i18n.tomland simplifies the implementation by only callingpartials/announcement.htmlandpartials/deprecationwarning.html, instead of calling to shortcodes as well.This PR does not remove the unused shortcodes. This will be done in a follow up task: see #21609.