-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CronJob page #18554
Improve CronJob page #18554
Conversation
This PR adds a note about the special constraint on CronJob names. The contstraint is not captured in the API specification or anywhere else to my knownledge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
One nit, optional to fix
Co-Authored-By: Tim Bannister <tim@scalefactory.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Improve CronJob page This PR adds a note about the special constraint on CronJob names. The contstraint is not captured in the API specification or anywhere else to my knownledge. * Update content/en/docs/concepts/workloads/controllers/cron-jobs.md Co-Authored-By: Tim Bannister <tim@scalefactory.com> Co-authored-by: Tim Bannister <tim@scalefactory.com>
This PR adds a note about the special constraint on CronJob names. The constraint is not captured in the API specification or anywhere else to my knowledge.