Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve service page #18429

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Improve service page #18429

merged 1 commit into from
Jan 15, 2020

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jan 3, 2020

This amends the service page for LoadBalancer type of services.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 3, 2020
sftim
sftim reviewed Jan 3, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I saw one nit that I think is worth fixing.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2020
@tengqm tengqm force-pushed the improve-service-page branch from 96a740e to 322dfdf Compare January 3, 2020 12:29
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2020
@sftim
Copy link
Contributor

sftim commented Jan 3, 2020

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jan 3, 2020
sftim
sftim reviewed Jan 3, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted a nit but it's tiny.

I'm actually not sure that I know the technical accuracy of this, so I don't think I should LGTM.
(if you can point me in the direction of evidence @tengqm that might be enough)

@tengqm
Improve service page
ee6861c 
This amends the service page for LoadBalancer type of services.
@tengqm tengqm force-pushed the improve-service-page branch from 322dfdf to ee6861c Compare January 4, 2020 01:15
@sftim
Copy link
Contributor

sftim commented Jan 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2020
@tengqm
Copy link
Contributor Author

tengqm commented Jan 9, 2020

Guard against multi-protocols for LB services: https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/validation/validation.go#L4001
Guard against protocols other than TCP, UDP or SCTP:
https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/validation/validation.go#L4006

sftim
sftim reviewed Jan 15, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit f4505fc into kubernetes:master Jan 15, 2020
wawa0210 pushed a commit to wawa0210/website that referenced this pull request Mar 2, 2020
@tengqm @wawa0210
Improve service page (kubernetes#18429)
f4880ff 
This amends the service page for LoadBalancer type of services.
@tengqm tengqm deleted the improve-service-page branch March 6, 2020 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@bprashanth bprashanth Awaiting requested review from bprashanth

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tengqm @sftim @k8s-ci-robot