-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deployment.md #17328
Update deployment.md #17328
Conversation
Modified kubectl get deployment command outputs to adapt them to the new output format introduced in v1.11
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @aelejota! |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 0a0c98a https://deploy-preview-17328--kubernetes-io-master-staging.netlify.com |
/assign @jaredbhatti |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: makoscafee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAME DESIRED CURRENT UP-TO-DATE AVAILABLE AGE
nginx-deployment 3 0 0 0 1s
NAME READY UP-TO-DATE AVAILABLE AGE
nginx-deployment 3/0 0 0 1s
READY should be 0/3.
kubectl get deploy
NAME READY UP-TO-DATE AVAILABLE AGE
nginx-deployment 0/2 2 0 5s
Fix a typo
@aelejota, it's better to squash this into one commit. |
Thanks @lojies |
@aelejota, you can reset your commit to HEAD~1, modify and commit --amend, then push force. |
/lgtm |
Thanks to you all for your help. It seems that droids did the job and both commits were combined |
Modified kubectl get deployment command outputs to adapt them to the new output format introduced in v1.11