Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content/es/docs/reference/glossary/volume.md #14901

Merged
merged 1 commit into from
Jul 28, 2019
Merged

Add content/es/docs/reference/glossary/volume.md #14901

merged 1 commit into from
Jul 28, 2019

Conversation

editaxz
Copy link
Contributor

@editaxz editaxz commented Jun 14, 2019

Añadimos la pagina de volumen al glosario

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 14, 2019
@k8s-ci-robot k8s-ci-robot added language/es Issues or PRs related to Spanish language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 14, 2019
@editaxz
Copy link
Contributor Author

editaxz commented Jun 14, 2019

/assign @raelga

@netlify
Copy link

netlify bot commented Jun 14, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0f368c4

https://deploy-preview-14901--kubernetes-io-master-staging.netlify.com

sftim
sftim reviewed Jun 14, 2019
View reviewed changes
content/es/docs/reference/glossary/volume.md Outdated

<!--more-->

Un volumen de Kubernetes viven mientras el {{< glossary_tooltip text="pod" term_id="pod" >}} esta corriendo. Un volumen persiste mientra exista el {{< glossary_tooltip text="pod" term_id="pod" >}}, no depende de la vida del {{< glossary_tooltip text="container" term_id="container" >}}, y por eso se conservan los datos entre los reinicios de los mismos.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Un volumen de Kubernetes viven mientras el {{< glossary_tooltip text="pod" term_id="pod" >}} esta corriendo. Un volumen persiste mientra exista el {{< glossary_tooltip text="pod" term_id="pod" >}}, no depende de la vida del {{< glossary_tooltip text="container" term_id="container" >}}, y por eso se conservan los datos entre los reinicios de los mismos.
Un volumen de Kubernetes viven mientras el {{< glossary_tooltip text="pod" term_id="pod" >}} esta corriendo. Un volumen persiste mientra exista el {{< glossary_tooltip text="pod" term_id="pod" >}}, no depende de la vida del {{< glossary_tooltip text="contenador" term_id="container" >}}, y por eso se conservan los datos entre los reinicios de los mismos.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sftim , why did you change "container" for "contenador"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think he meant 'contenedor'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, contenedor indeed.

@raelga
Copy link
Member

raelga commented Jun 22, 2019

Buenas @editaxz!

Por mi parte está perfecto a parte del doble espacio. De cara a publicarlo, podrías squashearlo todo en un único commit?

¡Muchas gracias!

@raelga raelga mentioned this pull request Jun 22, 2019
Closed
@raelga
Copy link
Member

raelga commented Jul 27, 2019

Buenas @editaxz!

Solo quedaría hacer un squash para dejarlo en un único commit y está listo para publicar!

Si quieres, lo miramos por slack.

@editaxz
add content/es/docs/reference/glossary/volume.md
0f368c4 
Suggestions glo-pena done

Fixing glo-pena  suggestions

remove space before container word

remove space before container word
@editaxz editaxz force-pushed the add-content/es/docs/concepts/volum branch from c58293d to 0f368c4 Compare July 28, 2019 08:34
@editaxz
Copy link
Contributor Author

editaxz commented Jul 28, 2019

Buenas noches @raelga , este último commit ya tiene el squash . Muchas gracias.

@raelga
Copy link
Member

raelga commented Jul 28, 2019

Muchas gracias @editaxz !

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9eeb013 into kubernetes:master Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@raelga raelga raelga left review comments

@glo-pena glo-pena glo-pena requested changes

@alexbrand alexbrand Awaiting requested review from alexbrand

Assignees

@raelga raelga

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/es Issues or PRs related to Spanish language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@editaxz @raelga @k8s-ci-robot @glo-pena @sftim