Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i18n-zh work base branch in PULL_REQUEST_TEMPLATE.md #14265

Merged
merged 1 commit into from
May 11, 2019
Merged

Update i18n-zh work base branch in PULL_REQUEST_TEMPLATE.md #14265

merged 1 commit into from
May 11, 2019

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented May 10, 2019

Relates to #14143

/cc @kubernetes/sig-docs-zh-owners
/cc @SataQiu @xichengliudui @tengqm @markthink @zhangxiaoyu-zidif

@k8s-ci-robot k8s-ci-robot requested a review from a team May 10, 2019 15:39
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 10, 2019
@chenrui333
Copy link
Member Author

@chenrui333 chenrui333 changed the title Update i18n-zh work base branch Update i18n-zh work base branch in PULL_REQUEST_TEMPLATE.md May 10, 2019
@netlify
Copy link

netlify bot commented May 10, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit bf0a8b7

https://deploy-preview-14265--kubernetes-io-master-staging.netlify.com

@SataQiu
Copy link
Member

SataQiu commented May 11, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2019
@SataQiu
Copy link
Member

SataQiu commented May 11, 2019

/assign @zacharysarah
We are now working on release-1.14 and need your approval 😆

@zacharysarah
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit dd677bc into kubernetes:master May 11, 2019
yoonian pushed a commit to yoonian/kubernetes-website that referenced this pull request May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants