-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update abac.md #13067
Update abac.md #13067
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 1c7d01d https://deploy-preview-13067--kubernetes-io-master-staging.netlify.com |
/sig auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: This ABAC Authorization feature has been deprecated
It would be great if you could provide more details about the release number in which it was deprecated.
@@ -8,6 +8,7 @@ title: Using ABAC Authorization | |||
content_template: templates/concept | |||
weight: 80 | |||
--- | |||
(NOTE: This ABAC Authorization feature has been deprecated ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(NOTE: This ABAC Authorization feature has been deprecated ) | |
{{< note >}}This ABAC Authorization feature has been deprecated{{< /note >}} |
We have a Hugo shortcode that lets you call out a note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -8,6 +8,7 @@ title: Using ABAC Authorization | |||
content_template: templates/concept | |||
weight: 80 | |||
--- | |||
{{< note >}}This ABAC Authorization feature has been considered deprecated from Kubernetes 1.6 release{{< /note >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps instead use the feature-state shortcode. And I believe if you put in the {{% capture overview %}} section it will show up at the top of the page instead of the bottom. So instead do the following.
{{< note >}}
{{< feature-state state="deprecated" for_k8s_version="1.6" >}}
The ABAC Authorization feature has been considered deprecated from the Kubernetes 1.6 release.
{{< /note >}}
See my inline comment. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update abac.md * Update abac.md * Update abac.md
* Update abac.md * Update abac.md * Update abac.md
I am trying to understand how this change came about. I just started the deprecation process for ABAC in 1.17 via kubernetes/kubernetes#82540. I was surprised to find that the docs stated a deprecation in 1.6. I doubt we would have done that, since RBAC and the related ecosystem were not very mature at the time. |
@kubernetes/sig-auth-pr-reviews |
agreed, ABAC has not been deprecated until now |
This reverts commit 0ceb362.
add deprecation for abac authorization
fixes #13021