Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update abac.md #13067

Merged
merged 3 commits into from
Apr 10, 2019
Merged

Update abac.md #13067

merged 3 commits into from
Apr 10, 2019

Conversation

RA489
Copy link

@RA489 RA489 commented Mar 11, 2019 •
edited
Loading

add deprecation for abac authorization
fixes #13021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2019
@netlify
Copy link

netlify bot commented Mar 11, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 1c7d01d

https://deploy-preview-13067--kubernetes-io-master-staging.netlify.com

@Rajakavitha1
Copy link
Contributor

Rajakavitha1 commented Mar 11, 2019 •
edited
Loading

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Mar 11, 2019
Rajakavitha1
Rajakavitha1 reviewed Mar 11, 2019
View reviewed changes
Copy link
Contributor

@Rajakavitha1 Rajakavitha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This ABAC Authorization feature has been deprecated

It would be great if you could provide more details about the release number in which it was deprecated.

sftim
sftim reviewed Mar 11, 2019
View reviewed changes
content/en/docs/reference/access-authn-authz/abac.md Outdated
@@ -8,6 +8,7 @@ title: Using ABAC Authorization
content_template: templates/concept
weight: 80
---
(NOTE: This ABAC Authorization feature has been deprecated )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(NOTE: This ABAC Authorization feature has been deprecated )
{{< note >}}This ABAC Authorization feature has been deprecated{{< /note >}}

We have a Hugo shortcode that lets you call out a note.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bradtopol bradtopol self-assigned this Mar 16, 2019
bradtopol
bradtopol reviewed Mar 16, 2019
View reviewed changes
content/en/docs/reference/access-authn-authz/abac.md Outdated
@@ -8,6 +8,7 @@ title: Using ABAC Authorization
content_template: templates/concept
weight: 80
---
{{< note >}}This ABAC Authorization feature has been considered deprecated from Kubernetes 1.6 release{{< /note >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps instead use the feature-state shortcode. And I believe if you put in the {{% capture overview %}} section it will show up at the top of the page instead of the bottom. So instead do the following.
{{< note >}}
{{< feature-state state="deprecated" for_k8s_version="1.6" >}}
The ABAC Authorization feature has been considered deprecated from the Kubernetes 1.6 release.
{{< /note >}}

@bradtopol
Copy link
Contributor

See my inline comment.
Perhaps instead use the feature-state shortcode as recommended in the style guide.. (https://kubernetes.io/docs/contribute/style/hugo-shortcodes/)
And I believe if you put in the {{% capture overview %}} section it will show up at the top of the page instead of the bottom. So instead do the following:
{{< note >}}
{{< feature-state state="deprecated" for_k8s_version="1.6" >}}
The ABAC Authorization feature has been considered deprecated from the Kubernetes 1.6 release.
{{< /note >}}

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 25, 2019
@tengqm
Copy link
Contributor

tengqm commented Apr 10, 2019

/lgtm
/approve
Feedbacks all resolved.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0ceb362 into kubernetes:master Apr 10, 2019
McCoyAle pushed a commit to McCoyAle/website that referenced this pull request Apr 16, 2019
@McCoyAle
Update abac.md (kubernetes#13067)
2f5d5e7 
* Update abac.md

* Update abac.md

* Update abac.md
nowjean pushed a commit to nowjean/website that referenced this pull request Jun 13, 2019
@nowjean
Update abac.md (kubernetes#13067)
4559c19 
* Update abac.md

* Update abac.md

* Update abac.md
@enj
Copy link
Member

enj commented Sep 10, 2019 •
edited
Loading

I am trying to understand how this change came about. I just started the deprecation process for ABAC in 1.17 via kubernetes/kubernetes#82540. I was surprised to find that the docs stated a deprecation in 1.6. I doubt we would have done that, since RBAC and the related ecosystem were not very mature at the time.

@enj
Copy link
Member

enj commented Sep 10, 2019

@kubernetes/sig-auth-pr-reviews

@enj enj mentioned this pull request Sep 10, 2019
Closed
@liggitt
Copy link
Member

liggitt commented Sep 11, 2019

I was surprised to find that the docs stated a deprecation in 1.6.

agreed, ABAC has not been deprecated until now

tengqm added a commit that referenced this pull request Sep 11, 2019
@tengqm
Revert "Update abac.md (#13067)"
187118c 
This reverts commit 0ceb362.
@tengqm tengqm mentioned this pull request Sep 11, 2019
Merged
tengqm added a commit that referenced this pull request Sep 11, 2019
@tengqm
Revert "Update abac.md (#13067)" (#16302)
bb03bc0 
This reverts commit 0ceb362.
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 18, 2019
@tengqm @wahyuoi
Revert "Update abac.md (kubernetes#13067)" (kubernetes#16302)
550334a 
This reverts commit 0ceb362.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradtopol bradtopol bradtopol left review comments

@sftim sftim sftim left review comments

@Rajakavitha1 Rajakavitha1 Rajakavitha1 left review comments

@erictune erictune Awaiting requested review from erictune

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@tengqm tengqm

@bradtopol bradtopol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Deprecation status info to k8s.io/docs/reference/access-authn-authz/abac/
8 participants
@RA489 @Rajakavitha1 @bradtopol @tengqm @k8s-ci-robot @enj @liggitt @sftim