Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API reference for 1.13 #11341

Closed
wants to merge 19 commits into from
Closed

API reference for 1.13 #11341

wants to merge 19 commits into from

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Nov 27, 2018

Adding this now because there are PRs which wants to reference the API resources added or changed, e.g. #9947.

nikhita and others added 19 commits November 1, 2018 14:13
* Update outdated l10n(ko) contents (kubernetes#10689)

fixes kubernetes#10686

* Translate concepts/overview/what-is-kubernetes in Korean (kubernetes#10690)

* Translate concepts/overview/what-is-kubernetes in Korean

* Feedback from ClaudiaJKang

* Translate concepts/overview/components in Korean (kubernetes#10882)

* Translate concepts/overview/components in Korean kubernetes#10717

* Translate concepts/overview/components in Korean

* Translate concepts/overview/components in Korean

* Apply Korean glossary: 서비스 어카운트

* Translate concepts/overview/kubernetes-api in Korean (kubernetes#10773)

* Translate concepts/overview/kubernetes-api in Korean

* Applied feedback from ianychoi
…tes#11031)

* ADD content/zh/docs/reference/setup-tools/kubeadm/kubeadm.md

* ADD content/zh/docs/reference/setup-tools/kubeadm/generated/kubeadm_init.md

* Update content/zh/docs/reference/setup-tools/kubeadm/kubeadm.md

Accepted

Co-Authored-By: YouthLab <tsui@highyouth.com>

* do not change 'master' or 'worker' nodes to '主从'
* Doc updates for volume scheduling GA

* Make trivial change to kick build
EncryptionConfig was renamed to EncryptedConfiguration and added to
the `apiserver.config.k8s.io` API group in Kubernetes 1.13.

The feature was previously in alpha and was not handling versions
properly, which lead to an originally unnoticed `v1` in the docs.
* trsanlate create-cluster-kubeadm.md to chinese

* Update create-cluster-kubeadm.md
content/zh/docs/reference/setup-tools/kubeadm/kubeadm-init.md
Adding this now because there are PRs which wants to reference the API
resources added or changed.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 27, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit e1c3e22

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5bfcbb5de5cd164a691fc249

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tengqm

If they are not already assigned, you can assign the PR to them by writing /assign @tengqm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 27, 2018
@Bradamant3 Bradamant3 added this to the 1.13 milestone Nov 27, 2018
@Bradamant3 Bradamant3 requested review from tfogo and removed request for Rajakavitha1 November 27, 2018 16:15
@Bradamant3 Bradamant3 requested review from steveperry-53 and removed request for tfogo November 27, 2018 16:15
@Bradamant3
Copy link
Contributor

@steveperry-53 do you have time to look at this one for a sanity check? Qiming rocks the generated docs, but one more pair of eyes is always good in this obscure corner of the docs world.

@tfogo
Copy link
Contributor

tfogo commented Nov 27, 2018

@tengqm Fantastic thanks!

@@ -20,6 +20,7 @@ This section of the Kubernetes documentation contains references.

* [Kubernetes API Overview](/docs/reference/using-api/api-overview/) - Overview of the API for Kubernetes.
* Kubernetes API Versions
* [1.13](/docs/reference/generated/kubernetes-api/v1.13/)
* [1.12](/docs/reference/generated/kubernetes-api/v1.12/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tengqm, will this page eventually have the recent updates to all pages, such as the feedback section?
Perhaps this happens once this branch is merged to dev-1.13 and then master?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, @kbhawkey, when new changes made to 1.13 api, the docs should be updated as well. The sad thing is that we don't have an auto-triggering mechanism for this. The best workaround I can think of is to have the upstream code changes mention sig-docs.

@tfogo
Copy link
Contributor

tfogo commented Dec 3, 2018

Hi @tengqm - this got out of sync with dev-1.13 and I don't want to have to do another rebase. So I regenerated the docs and made a PR here: #11489

If I missed anything, please let me know. Will close this PR though.
/close

@k8s-ci-robot
Copy link
Contributor

@tfogo: Closed this PR.

In response to this:

Hi @tengqm - this got out of sync with dev-1.13 and I don't want to have to do another rebase. So I regenerated the docs and made a PR here: #11489

If I missed anything, please let me know. Will close this PR though.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tengqm tengqm deleted the api-doc-1.13 branch July 5, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.