Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR template for 1.13 release #10603

Merged
merged 2 commits into from
Oct 13, 2018
Merged

Update PR template for 1.13 release #10603

merged 2 commits into from
Oct 13, 2018

Conversation

tfogo
Copy link
Contributor

@tfogo tfogo commented Oct 12, 2018

Using the new dev-1.13 branch.

@tfogo
Update PR template for 1.13 release
e124ff8 
Also updates links to documentation for submitting PRs
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 12, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging failed.

Built with commit 3f78789

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5bc12eb9b3127436e00381bb

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 12, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging failed.

Built with commit b2ff864

https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5bc1328f82d3f1277b16f965

@tfogo
Copy link
Contributor Author

tfogo commented Oct 12, 2018

/assign @zacharysarah

zacharysarah
zacharysarah reviewed Oct 12, 2018
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tfogo For start.md you can also use a short code: {{< release-branch >}} if you want to future-proof a little.

@tfogo
Copy link
Contributor Author

tfogo commented Oct 12, 2018

@zacharysarah Nice, will make that change.

@tfogo
Update contributing docs for new branch strategy
b2ff864 
Branches for upcoming releases are now dev-X.Y instead of
release-X.Y
@tfogo tfogo force-pushed the tf-update-pr-info branch from 3f78789 to b2ff864 Compare October 12, 2018 23:47
@zacharysarah
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2018
@k8s-ci-robot k8s-ci-robot merged commit 9abeb8b into kubernetes:master Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharysarah zacharysarah zacharysarah left review comments

@jimangel jimangel Awaiting requested review from jimangel

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

Assignees

@zacharysarah zacharysarah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tfogo @k8sio-netlify-preview-bot @zacharysarah @k8s-ci-robot @kubernetes-docs-i18n-bot