Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation docs don't explain webhooks #9622

Closed
1 of 2 tasks
rcorre opened this issue Jul 23, 2018 · 1 comment
Closed
1 of 2 tasks

Aggregation docs don't explain webhooks #9622

rcorre opened this issue Jul 23, 2018 · 1 comment

Comments

@rcorre
Copy link
Contributor

rcorre commented Jul 23, 2018

This is a...

  • Feature Request
  • Bug Report

Problem:

The aggregation docs mention "Webooks" several times when comparing CRDs to API server aggregation. For example, the table comparing the two has these rows:

Feature Description CRDs
Validation Help users prevent errors and allow you to evolve your API independently of your clients. These features are most useful when there are many clients who can’t all update at the same time. Yes. Most validation can be specified in the CRD using OpenAPI v3.0 validation. Any other validations supported by addition of a Validating Webhook
Custom Business Logic Perform arbitrary checks or actions when creating, reading, updating or deleting an object Yes, using Webhooks.

So how do I actually use "webhooks" to implement validation or custom business logic? There are no links here, so I searched and found the docs on Webhook Mode, which seems to be about auth, and admission controllers, which only discusses built-in controllers. I'm not even clear if I can create my own admission controller:

The controllers consist of the list below,

Proposed Solution:

Include a section or separate page on how to use webhooks for CRD business logic and validation, or at least make and reference to "Webhooks" a link to the page explaining this kubernetes feature, since neither of the pages I found seem to be relevant.

Page to Update:
https://kubernetes.io/docs/concepts/extend-kubernetes/api-extension/custom-resources/#api-server-aggregation

@CaoShuFeng
Copy link
Contributor

Hi.

#9676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants