-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JobSet labels and annotations not registered / documented #47373
Comments
/sig docs |
/priority backlog |
I will try to add PR for this. /assign |
@sftim why should these annotations and labels be added if they are not in the I don't see any other mentions of labels in the |
The question doesn't really make sense. This issue is about registering labels / annotations such as
k8s.io is an official domain; see the first sentence of https://kubernetes.io/docs/reference/labels-annotations-taints/ However, x-k8s.io is not. JobSet can use labels and annotations in that domain as much as it likes without registering them. Although, I still encourage SIGs to register official labels / annotations. They are available at the low, low price of $0. |
Interesting. I didn't know jobset was using the I thought there were some requirements to get to use that domain, like an official API review, but maybe I was thinking of API groups. |
My understanding is that they should have used |
This is a Bug Report
Problem:
The JobSet API and its controller use annotations that we haven't yet registered; see the description of kubernetes-sigs/jobset#639 for a list.
Proposed Solution:
Page to Update:
https://kubernetes.io/docs/reference/labels-annotations-taints/
/sig apps
/language en
The text was updated successfully, but these errors were encountered: