Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobSet labels and annotations not registered / documented #47373

Open
sftim opened this issue Aug 6, 2024 · 7 comments · May be fixed by #47383
Open

JobSet labels and annotations not registered / documented #47373

sftim opened this issue Aug 6, 2024 · 7 comments · May be fixed by #47383
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented Aug 6, 2024

This is a Bug Report

Problem:
The JobSet API and its controller use annotations that we haven't yet registered; see the description of kubernetes-sigs/jobset#639 for a list.

Proposed Solution:

  • Register (ie, document) these annotations / labels

Page to Update:
https://kubernetes.io/docs/reference/labels-annotations-taints/

/sig apps
/language en

@sftim sftim added the kind/bug Categorizes issue or PR as related to a bug. label Aug 6, 2024
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 6, 2024
@Adarsh-verma-14
Copy link
Contributor

/sig docs

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 6, 2024
@dipesh-rawat
Copy link
Member

/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 6, 2024
@Adarsh-verma-14
Copy link
Contributor

I will try to add PR for this.

/assign

@alculquicondor
Copy link
Member

@sftim why should these annotations and labels be added if they are not in the kubernetes.io domain?

I don't see any other mentions of labels in the x-k8s.io domain in https://kubernetes.io/docs/reference/labels-annotations-taints/

@sftim
Copy link
Contributor Author

sftim commented Oct 1, 2024

@sftim why should these annotations and labels be added if they are not in the kubernetes.io domain?

I don't see any other mentions of labels in the x-k8s.io domain in https://kubernetes.io/docs/reference/labels-annotations-taints/

The question doesn't really make sense. This issue is about registering labels / annotations such as

  • jobset.sigs.k8s.io/jobset-name
  • jobset.sigs.k8s.io/global-replicas

k8s.io is an official domain; see the first sentence of https://kubernetes.io/docs/reference/labels-annotations-taints/

However, x-k8s.io is not. JobSet can use labels and annotations in that domain as much as it likes without registering them. Although, I still encourage SIGs to register official labels / annotations. They are available at the low, low price of $0.

@alculquicondor
Copy link
Member

Interesting. I didn't know jobset was using the k8s.io domain instead of x-k8s.io.

I thought there were some requirements to get to use that domain, like an official API review, but maybe I was thinking of API groups.

@tengqm
Copy link
Contributor

tengqm commented Oct 1, 2024

My understanding is that they should have used x-k8s.io. We don't have any other documentation about JobSets on the website anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Needs Triage
Development

Successfully merging a pull request may close this issue.

6 participants