Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for k8s.io/docs/concepts/services-networking/service/ #44324

Open
alternaivan opened this issue Dec 13, 2023 · 8 comments
Open

Improvement for k8s.io/docs/concepts/services-networking/service/ #44324

alternaivan opened this issue Dec 13, 2023 · 8 comments
Assignees
Labels
language/en Issues or PRs related to English language sig/network Categorizes an issue or PR as relevant to SIG Network. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@alternaivan
Copy link

Hello,

I've been testing the type: ExternalName service and I found something that could be helpful if it's added to that part.

The documentation could contain a note somewhat similar to the below one:

If the external service has a valid domain name and you don’t need port remapping, then using the “ExternalName” service type is an easy and quick way to map the external service to an internal one. If you don’t have a domain name or need to do port remapping, simply add the IP addresses to an EndpointSlice and use that instead.

You can find the reference to the above under this link under Conclusion.

Thank you in advance!
Marjan

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 13, 2023
@dipesh-rawat
Copy link
Member

Page mentioned in the issue: https://kubernetes.io/docs/concepts/services-networking/service/
/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 13, 2023
@dipesh-rawat
Copy link
Member

/sig network

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Dec 13, 2023
@rohan-kapse
Copy link
Contributor

@alternaivan Proposed fix: To add a "NOTE" section under type: ExternalName and add the documentation suggested above to it.

@arujjval arujjval removed their assignment Dec 14, 2023
@arujjval
Copy link
Contributor

@rohan-kapse are you working on this?

@rohan-kapse
Copy link
Contributor

Go ahead.

@arujjval
Copy link
Contributor

@alternaivan Proposed fix: To add a "NOTE" section under type: ExternalName and add the documentation suggested above to it.

@dipesh-rawat Is this a valid fix?

@swastik959
Copy link

/assign

@natalisucks
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language sig/network Categorizes an issue or PR as relevant to SIG Network. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants