-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain how to tell dockershim apart from cri-dockerd #30974
Comments
Very relevant to #30972 |
It really should say It doesn't say "for cri-containerd" or "for containerd with cri plugin", either. Adding an example It is covered on https://kubernetes.io/docs/setup/production-environment/container-runtimes/ |
Neither They only describe the container runtime, and in some cases the API version... Needed to look at /etc/crictl.yaml directly. docker@minikube:~$ more /etc/crictl.yaml
runtime-endpoint: unix:///var/run/dockershim.sock
image-endpoint: unix:///var/run/dockershim.sock docker@minikube:~$ more /etc/crictl.yaml
runtime-endpoint: unix:///var/run/cri-docker.sock
image-endpoint: unix:///var/run/cri-docker.sock The output of
|
This comment has been minimized.
This comment has been minimized.
/triage accepted |
I think it would be more interesting to look at users using the "docker" container runtime, to see if they have changed CRI... They would need to change their CRI, from dockershim.sock to cri-dockerd.sock. Including kubelet and crictl configuration ? But they don't need to relearn everything or transfer images, etc. |
This should say "docker" (which the command does), and not They main reason is in the confusion between container runtimes, and the CRI being used for them ? https://kubernetes.io/docs/tasks/administer-cluster/migrating-from-dockershim/ "This section presents information you need to know when migrating from dockershim to other container runtimes." Which of course doesn't make any sense to begin with, since dockershim is not a container runtime. So it should be divided into two: 1) how to change dockershim to cri-dockerd 2) how to change docker to containerd Of course, if you are already set on replacing the container runtime, then you don't need to bother with the first one. |
That seems fair enough. We can also add instructions for switching your node from Docker Engine to something else, if we want. |
where feasible we prefer to link to external docs that are specific to external tools, rather than document them ourselves. |
Unfortunately it also assumes that there are any good external docs, which doesn't seem to be the case for either CRI ? It is a big problem for minikube, the only container runtime which is easy to install (i.e. get.docker.com) is no longer supported. So we end up having to pre-install all three of them, rather than doing some simple provisioning before the bootstrapping. "Patches accepted", I suppose... |
From what I understand, Find out what container runtime is used on a node needs to add info about how cri-dockerd users aren't affected, and how to check the CRI socket to tell if you do use cri-dockerd. (how? if crictl is not installed, is there another way?) Also, https://kubernetes.io/docs/tasks/administer-cluster/migrating-from-dockershim/ needs more guidance for migrating from dockershim to cri-dockerd (in addition to migrating from Docker Engine to containerd). Is this out of scope for this issue? /assign |
I'd say yes: it is out of scope for this issue. It's fine to track a separate issue to add docs for that. |
I believe that But I assume you would look at kubelet configuration If it doesn't have any configuration, it is using dockershim. And thus it would be affected by this change. So far, we don't know what the minimum requirements on Kubernetes version and Docker version is, for it. But we can assume that anything after 1.20 and 19.03 should be fine, for changing to cri-dockerd 0.2.x. The recommendation would probably be to go with 1.24 and 20.10, and assuming a real release of 0.2.1 ? This is now up to Mirantis to describe, for cri-dockerd.
|
There is a You can narrow it down by running |
It's all done! |
This is a Feature Request
What would you like to be added
Update https://kubernetes.io/docs/tasks/administer-cluster/migrating-from-dockershim/find-out-runtime-you-use/ to explain how to tell apart two cases that involve Docker Engine as a container runtime
The second case, using 2 third-party components, is not affected by the dockership deprecation. As a project we are not telling cri-dockerd users to migrate away.
Why is this needed
If someone is using cri-dockerd with Docker Engine, they don't need to take action relating to the deprecation of dockershim. That person might visit https://kubernetes.io/docs/tasks/administer-cluster/migrating-from-dockershim/find-out-runtime-you-use/ and then be confused about whether they still need to take action.
Comments
/sig node
/priority important-soon
/language en
/kind feature
Part of kubernetes/kubernetes#104878
The text was updated successfully, but these errors were encountered: