Drop (Escape|Unescape)PluginName

Change-Id: I8b213a52dbd96c510e4f7173324e198f4caf55fd

Author: dims

strings/escape.go

@@ -20,19 +20,6 @@ import (
 	"strings"
 )
 
-// EscapePluginName converts a plugin name in the format
-// vendor/pluginname into a proper ondisk vendor~pluginname plugin directory
-// format.
-func EscapePluginName(in string) string {
-	return strings.Replace(in, "/", "~", -1)
-}
-
-// UnescapePluginName converts a plugin directory name in the format
-// vendor~pluginname into a proper vendor/pluginname.
-func UnescapePluginName(in string) string {
-	return strings.Replace(in, "~", "/", -1)
-}
-
 // EscapeQualifiedName converts a plugin name, which might contain a / into a
 // string that is safe to use on-disk.  This assumes that the input has already
 // been validates as a qualified name.  we use "~" rather than ":" here in case

strings/escape_test.go

@@ -20,27 +20,6 @@ import (
 	"testing"
 )
 
-func TestEscapePluginName(t *testing.T) {
-	testCases := []struct {
-		input  string
-		output string
-	}{
-		{"kubernetes.io/blah", "kubernetes.io~blah"},
-		{"blah/blerg/borg", "blah~blerg~borg"},
-		{"kubernetes.io", "kubernetes.io"},
-	}
-	for i, tc := range testCases {
-		escapee := EscapePluginName(tc.input)
-		if escapee != tc.output {
-			t.Errorf("case[%d]: expected (%q), got (%q)", i, tc.output, escapee)
-		}
-		original := UnescapePluginName(escapee)
-		if original != tc.input {
-			t.Errorf("case[%d]: expected (%q), got (%q)", i, tc.input, original)
-		}
-	}
-}
-
 func TestEscapeQualifiedNameForDisk(t *testing.T) {
 	testCases := []struct {
 		input  string