Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add website teams for /milestone #11838

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Add website teams for /milestone #11838

merged 1 commit into from
Mar 26, 2019

Conversation

zacharysarah
Copy link

@zacharysarah zacharysarah commented Mar 19, 2019 •
edited
Loading

💚 OK to merge 💚

Update: kubernetes/org#644 has merged, so this PR is 🆗 to merge.

For #11687 (comment).

This PR adds /milestone capability for localization subproject owners in k/website.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2019
@zacharysarah zacharysarah changed the title Add website team for /milestone [WIP] Add website team for /milestone Mar 19, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2019
@zacharysarah zacharysarah changed the title [WIP] Add website team for /milestone [WIP] Add website teams for /milestone Mar 19, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2019
@zacharysarah zacharysarah mentioned this pull request Mar 19, 2019
Closed
nikhita
nikhita reviewed Mar 20, 2019
View reviewed changes
prow/plugins.yaml Outdated Show resolved Hide resolved
@nikhita
Copy link
Member

nikhita commented Mar 20, 2019

You'll also need to explicitly enable the milestone plugin for the website repo. (like in #11833)

@zacharysarah zacharysarah mentioned this pull request Mar 20, 2019
Merged
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2019
@zacharysarah zacharysarah changed the title [WIP] Add website teams for /milestone Add website teams for /milestone Mar 20, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2019
@zacharysarah
Copy link
Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2019
nikhita
nikhita reviewed Mar 21, 2019
View reviewed changes
prow/plugins.yaml Outdated Show resolved Hide resolved
fejta
fejta reviewed Mar 22, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
the general concept. Nikhita seems to be doing great work with the actual review

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2019
Add website team for /milestone
920dfc6 
Add l10n admin for /milestone

Add each l10n team

Add a single team instead

Enable milestone for k/website

Update team ID
@zacharysarah
Copy link
Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2019
nikhita
nikhita approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 086d18a48d59b70b33c3b8a39c81da2d99de2659

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, nikhita, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9102cd1 into kubernetes:master Mar 26, 2019
@k8s-ci-robot
Copy link
Contributor

@zacharysarah: Updated the plugins configmap in namespace default using the following files:

  • key plugins.yaml using file prow/plugins.yaml

In response to this:

💚 OK to merge 💚

Update: kubernetes/org#644 has merged, so this PR is 🆗 to merge.

For #11687 (comment).

This PR adds /milestone capability for localization subproject owners in k/website.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zacharysarah zacharysarah deleted the website-milestone branch March 26, 2019 08:56
@zacharysarah
Copy link
Author

Thanks, @nikhita! 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta left review comments

@nikhita nikhita nikhita approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@cjwagner cjwagner Awaiting requested review from cjwagner

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zacharysarah @nikhita @k8s-ci-robot @fejta