Merge pull request #27050 from Abirdcfly/patch-2

k8s-ci-robot · web-flow · commit 0356a6cd59f7 · 2022-08-05T10:33:55.000-07:00
delete minor unreachable code caused by t.Fatalf
diff --git a/prow/spyglass/podlogartifact_fetcher_test.go b/prow/spyglass/podlogartifact_fetcher_test.go
@@ -94,7 +94,6 @@ func TestFetchArtifacts_Prow(t *testing.T) {
 			res, err := artifact.ReadAll()
 			if err != nil {
 				t.Fatalf("%s failed reading bytes of log. got err: %v", tc.name, err)
-				continue
 			}
 			if !bytes.Equal(tc.expected, res) {
 				t.Errorf("Unexpected result of reading pod logs, expected %q, got %q", tc.expected, res)

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,6 @@ func TestFetchArtifacts_Prow(t *testing.T) {`
`94`	`94`	`res, err := artifact.ReadAll()`
`95`	`95`	`if err != nil {`
`96`	`96`	`t.Fatalf("%s failed reading bytes of log. got err: %v", tc.name, err)`
`97`		`- continue`
`98`	`97`	`}`
`99`	`98`	`if !bytes.Equal(tc.expected, res) {`
`100`	`99`	`t.Errorf("Unexpected result of reading pod logs, expected %q, got %q", tc.expected, res)`