-
Notifications
You must be signed in to change notification settings - Fork 2.6k
/
jobs_test.go
1281 lines (1171 loc) · 39 KB
/
jobs_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/*
Copyright 2018 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package tests
// This file validates kubernetes's jobs configs.
// See also prow/config/jobstests for generic job tests that
// all deployments should consider using.
import (
"bytes"
"errors"
"flag"
"fmt"
"os"
"path"
"path/filepath"
"regexp"
"sort"
"strings"
"testing"
"time"
coreapi "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/sets"
prowapi "k8s.io/test-infra/prow/apis/prowjobs/v1"
cfg "k8s.io/test-infra/prow/config"
)
var configPath = flag.String("config", "../../../config/prow/config.yaml", "Path to prow config")
var jobConfigPath = flag.String("job-config", "../../jobs", "Path to prow job config")
var deckPath = flag.String("deck-path", "https://prow.k8s.io", "Path to deck")
var bucket = flag.String("bucket", "kubernetes-jenkins", "Gcs bucket for log upload")
var k8sProw = flag.Bool("k8s-prow", true, "If the config is for k8s prow cluster")
// Loaded at TestMain.
var c *cfg.Config
func TestMain(m *testing.M) {
flag.Parse()
if *configPath == "" {
fmt.Println("--config must set")
os.Exit(1)
}
conf, err := cfg.Load(*configPath, *jobConfigPath)
if err != nil {
fmt.Printf("Could not load config: %v", err)
os.Exit(1)
}
c = conf
os.Exit(m.Run())
}
func TestReportTemplate(t *testing.T) {
var testcases = []struct {
org string
repo string
number int
suffix string
}{
{
org: "o",
repo: "r",
number: 4,
suffix: "?org=o&repo=r&pr=4",
},
{
org: "kubernetes",
repo: "test-infra",
number: 123,
suffix: "?org=kubernetes&repo=test-infra&pr=123",
},
{
org: "kubernetes",
repo: "kubernetes",
number: 123,
suffix: "?org=kubernetes&repo=kubernetes&pr=123",
},
{
org: "o",
repo: "kubernetes",
number: 456,
suffix: "?org=o&repo=kubernetes&pr=456",
},
}
for _, tc := range testcases {
var b bytes.Buffer
refs := &prowapi.Refs{
Org: tc.org,
Repo: tc.repo,
Pulls: []prowapi.Pull{
{
Number: tc.number,
},
},
}
reportTemplate := c.Plank.ReportTemplateForRepo(refs)
if err := reportTemplate.Execute(&b, &prowapi.ProwJob{Spec: prowapi.ProwJobSpec{Refs: refs}}); err != nil {
t.Errorf("Error executing template: %v", err)
continue
}
expectedPath := *deckPath + "/pr-history" + tc.suffix
if !strings.Contains(b.String(), expectedPath) {
t.Errorf("Expected template to contain %s, but it didn't: %s", expectedPath, b.String())
}
}
}
func TestURLTemplate(t *testing.T) {
testcases := []struct {
name string
jobType prowapi.ProwJobType
org string
repo string
job string
build string
expect string
k8sOnly bool
}{
{
name: "k8s presubmit",
jobType: prowapi.PresubmitJob,
org: "kubernetes",
repo: "kubernetes",
job: "k8s-pre-1",
build: "1",
expect: *deckPath + "/view/gcs/" + *bucket + "/pr-logs/pull/0/k8s-pre-1/1/",
k8sOnly: true,
},
{
name: "k8s-security presubmit",
jobType: prowapi.PresubmitJob,
org: "kubernetes-security",
repo: "kubernetes",
job: "k8s-pre-1",
build: "1",
expect: "https://console.cloud.google.com/storage/browser/kubernetes-security-prow/pr-logs/pull/kubernetes-security_kubernetes/0/k8s-pre-1/1/",
k8sOnly: true,
},
{
name: "k8s/test-infra presubmit",
jobType: prowapi.PresubmitJob,
org: "kubernetes",
repo: "test-infra",
job: "ti-pre-1",
build: "1",
expect: *deckPath + "/view/gcs/" + *bucket + "/pr-logs/pull/test-infra/0/ti-pre-1/1/",
k8sOnly: true,
},
{
name: "foo/k8s presubmit",
jobType: prowapi.PresubmitJob,
org: "foo",
repo: "kubernetes",
job: "k8s-pre-1",
build: "1",
expect: *deckPath + "/view/gcs/" + *bucket + "/pr-logs/pull/foo_kubernetes/0/k8s-pre-1/1/",
},
{
name: "foo-bar presubmit",
jobType: prowapi.PresubmitJob,
org: "foo",
repo: "bar",
job: "foo-pre-1",
build: "1",
expect: *deckPath + "/view/gcs/" + *bucket + "/pr-logs/pull/foo_bar/0/foo-pre-1/1/",
},
{
name: "k8s postsubmit",
jobType: prowapi.PostsubmitJob,
org: "kubernetes",
repo: "kubernetes",
job: "k8s-post-1",
build: "1",
expect: *deckPath + "/view/gcs/" + *bucket + "/logs/k8s-post-1/1/",
},
{
name: "k8s periodic",
jobType: prowapi.PeriodicJob,
job: "k8s-peri-1",
build: "1",
expect: *deckPath + "/view/gcs/" + *bucket + "/logs/k8s-peri-1/1/",
},
{
name: "empty periodic",
jobType: prowapi.PeriodicJob,
job: "nan-peri-1",
build: "1",
expect: *deckPath + "/view/gcs/" + *bucket + "/logs/nan-peri-1/1/",
},
{
name: "k8s batch",
jobType: prowapi.BatchJob,
org: "kubernetes",
repo: "kubernetes",
job: "k8s-batch-1",
build: "1",
expect: *deckPath + "/view/gcs/" + *bucket + "/pr-logs/pull/batch/k8s-batch-1/1/",
k8sOnly: true,
},
{
name: "foo bar batch",
jobType: prowapi.BatchJob,
org: "foo",
repo: "bar",
job: "k8s-batch-1",
build: "1",
expect: *deckPath + "/view/gcs/" + *bucket + "/pr-logs/pull/foo_bar/batch/k8s-batch-1/1/",
},
}
for _, tc := range testcases {
if !*k8sProw && tc.k8sOnly {
continue
}
var pj = prowapi.ProwJob{
ObjectMeta: metav1.ObjectMeta{Name: tc.name},
Spec: prowapi.ProwJobSpec{
Type: tc.jobType,
Job: tc.job,
},
Status: prowapi.ProwJobStatus{
BuildID: tc.build,
},
}
if tc.jobType != prowapi.PeriodicJob {
pj.Spec.Refs = &prowapi.Refs{
Pulls: []prowapi.Pull{{}},
Org: tc.org,
Repo: tc.repo,
}
}
var b bytes.Buffer
if err := c.Plank.JobURLTemplate.Execute(&b, &pj); err != nil {
t.Fatalf("Error executing template: %v", err)
}
res := b.String()
if res != tc.expect {
t.Errorf("tc: %s, Expect URL: %s, got %s", tc.name, tc.expect, res)
}
}
}
func checkContext(t *testing.T, repo string, p cfg.Presubmit) {
if !p.SkipReport && p.Name != p.Context {
t.Errorf("Context does not match job name: %s in %s", p.Name, repo)
}
}
func TestContextMatches(t *testing.T) {
for repo, presubmits := range c.PresubmitsStatic {
for _, p := range presubmits {
checkContext(t, repo, p)
}
}
}
func checkRetest(t *testing.T, repo string, presubmits []cfg.Presubmit) {
for _, p := range presubmits {
expected := fmt.Sprintf("/test %s", p.Name)
if p.RerunCommand != expected {
t.Errorf("%s in %s rerun_command: %s != expected: %s", repo, p.Name, p.RerunCommand, expected)
}
}
}
func TestRetestMatchJobsName(t *testing.T) {
for repo, presubmits := range c.PresubmitsStatic {
checkRetest(t, repo, presubmits)
}
}
type SubmitQueueConfig struct {
// this is the only field we need for the tests below
RequiredRetestContexts string `json:"required-retest-contexts"`
}
func findRequired(t *testing.T, presubmits []cfg.Presubmit) []string {
var required []string
for _, p := range presubmits {
if !p.AlwaysRun {
continue
}
if p.SkipReport {
continue
}
required = append(required, p.Context)
}
return required
}
// Enforce conventions for jobs that run in test-infra-trusted cluster
func TestTrustedJobs(t *testing.T) {
// TODO(fejta): allow each config/jobs/kubernetes/foo/foo-trusted.yaml
// that uses a foo-trusted cluster
const trusted = "test-infra-trusted"
trustedPath := path.Join(*jobConfigPath, "kubernetes", "test-infra", "test-infra-trusted.yaml")
// Presubmits may not use trusted clusters.
for _, pre := range c.AllStaticPresubmits(nil) {
if pre.Cluster == trusted {
t.Errorf("%s: presubmits cannot use trusted clusters", pre.Name)
}
}
// Trusted postsubmits must be defined in trustedPath
for _, post := range c.AllStaticPostsubmits(nil) {
if post.Cluster == trusted && post.SourcePath != trustedPath {
t.Errorf("%s defined in %s may not run in trusted cluster", post.Name, post.SourcePath)
}
}
// Trusted periodics must be defined in trustedPath
for _, per := range c.AllPeriodics() {
if per.Cluster == trusted && per.SourcePath != trustedPath {
t.Errorf("%s defined in %s may not run in trusted cluster", per.Name, per.SourcePath)
}
}
}
// Enforce conventions for jobs that run in k8s-infra-prow-build-trusted cluster
func TestK8sInfraTrusted(t *testing.T) {
const trusted = "k8s-infra-prow-build-trusted"
trustedPath := path.Join(*jobConfigPath, "kubernetes", "wg-k8s-infra", "trusted") + "/"
imagePushingDir := path.Join(*jobConfigPath, "image-pushing") + "/"
// Presubmits may not use this cluster
for _, pre := range c.AllStaticPresubmits(nil) {
if pre.Cluster == trusted {
t.Errorf("%s: presubmits may not run in cluster: %s", pre.Name, trusted)
}
}
// Postsubmits and periodics must
// - be defined in config/jobs/image-pushing/ and be a valid image-pushing job, OR
// - be defined in config/jobs/kubernetes/wg-k8s-infra/trusted/
jobs := []cfg.JobBase{}
for _, job := range c.AllStaticPostsubmits(nil) {
jobs = append(jobs, job.JobBase)
}
for _, job := range c.AllPeriodics() {
jobs = append(jobs, job.JobBase)
}
for _, job := range jobs {
if job.Cluster != trusted {
continue
}
if strings.HasPrefix(job.SourcePath, imagePushingDir) {
if err := validateImagePushingImage(job.Spec); err != nil {
t.Errorf("%s defined in %s %s", job.Name, job.SourcePath, err)
}
} else if !strings.HasPrefix(job.SourcePath, trustedPath) {
t.Errorf("%s defined in %s may not run in cluster: %s", job.Name, job.SourcePath, trusted)
}
}
}
func validateImagePushingImage(spec *coreapi.PodSpec) error {
const imagePushingImage = "gcr.io/k8s-testimages/image-builder"
for _, c := range spec.Containers {
if !strings.HasPrefix(c.Image, imagePushingImage+":") {
return fmt.Errorf("must use a pinned version of %s", imagePushingImage)
}
}
return nil
}
// Unit test only postsubmit/periodic jobs in config/jobs/<org>/<project>/<project>-trusted.yaml can use
// secrets for <org>/<project> in default public cluster.
func TestTrustedJobSecretsRestricted(t *testing.T) {
secretsRestricted := map[string]sets.String{
"kubernetes-sigs/sig-storage-local-static-provisioner": sets.NewString("sig-storage-local-static-provisioner-pusher"),
}
allSecrets := sets.String{}
for _, secrets := range secretsRestricted {
allSecrets.Insert(secrets.List()...)
}
isSecretUsedByContainer := func(secret string, container coreapi.Container) bool {
if container.EnvFrom == nil {
return false
}
for _, envFrom := range container.EnvFrom {
if envFrom.SecretRef != nil && envFrom.SecretRef.Name == secret {
return true
}
}
return false
}
isSecretUsed := func(secret string, job cfg.JobBase) bool {
if job.Spec == nil {
return false
}
if job.Spec.Volumes != nil {
for _, v := range job.Spec.Volumes {
if v.VolumeSource.Secret != nil {
if v.VolumeSource.Secret.SecretName == secret {
return true
}
}
}
}
if job.Spec.Containers != nil {
for _, c := range job.Spec.Containers {
if isSecretUsedByContainer(secret, c) {
return true
}
}
}
if job.Spec.InitContainers != nil {
for _, c := range job.Spec.InitContainers {
if isSecretUsedByContainer(secret, c) {
return true
}
}
}
return false
}
// All presubmit jobs should not use any restricted secrets.
for _, job := range c.AllStaticPresubmits(nil) {
if job.Cluster != prowapi.DefaultClusterAlias {
// check against default public cluster only
continue
}
for _, secret := range allSecrets.List() {
if isSecretUsed(secret, job.JobBase) {
t.Errorf("%q defined in %q may not use secret %q in %q cluster", job.Name, job.SourcePath, secret, job.Cluster)
}
}
}
secretsCanUseByPath := func(path string) sets.String {
cleanPath := strings.Trim(strings.TrimPrefix(path, *jobConfigPath), string(filepath.Separator))
seps := strings.Split(cleanPath, string(filepath.Separator))
if len(seps) <= 2 {
return nil
}
org := seps[0]
project := seps[1]
basename := seps[2]
if basename != fmt.Sprintf("%s-trusted.yaml", project) {
return nil
}
return secretsRestricted[fmt.Sprintf("%s/%s", org, project)]
}
// Postsubmit/periodic jobs defined in
// config/jobs/<org>/<project>/<project>-trusted.yaml can and only can use restricted
// secrets for <org>/repo>.
jobs := []cfg.JobBase{}
for _, job := range c.AllStaticPostsubmits(nil) {
jobs = append(jobs, job.JobBase)
}
for _, job := range c.AllPeriodics() {
jobs = append(jobs, job.JobBase)
}
for _, job := range jobs {
if job.Cluster != prowapi.DefaultClusterAlias {
// check against default public cluster only
continue
}
secretsCanUse := secretsCanUseByPath(job.SourcePath)
for _, secret := range allSecrets.List() {
if secretsCanUse != nil && secretsCanUse.Has(secret) {
t.Logf("allow secret %v for job %s defined in %s", secret, job.Name, job.SourcePath)
continue
}
if isSecretUsed(secret, job) {
t.Errorf("%q defined in %q may not use secret %q in %q cluster", job.Name, job.SourcePath, secret, job.Cluster)
}
}
}
}
// Unit test jobs outside kubernetes-security do not use the security cluster
// and that jobs inside kubernetes-security DO
func TestConfigSecurityClusterRestricted(t *testing.T) {
for repo, jobs := range c.PresubmitsStatic {
if strings.HasPrefix(repo, "kubernetes-security/") {
for _, job := range jobs {
if job.Agent != "jenkins" && job.Cluster != "security" {
t.Fatalf("Jobs in kubernetes-security/* should use the security cluster! %s", job.Name)
}
}
} else {
for _, job := range jobs {
if job.Cluster == "security" {
t.Fatalf("Jobs not in kubernetes-security/* should not use the security cluster! %s", job.Name)
}
}
}
}
for repo, jobs := range c.PostsubmitsStatic {
if strings.HasPrefix(repo, "kubernetes-security/") {
for _, job := range jobs {
if job.Agent != "jenkins" && job.Cluster != "security" {
t.Fatalf("Jobs in kubernetes-security/* should use the security cluster! %s", job.Name)
}
}
} else {
for _, job := range jobs {
if job.Cluster == "security" {
t.Fatalf("Jobs not in kubernetes-security/* should not use the security cluster! %s", job.Name)
}
}
}
}
// TODO: this will need to be more complex if we ever add k-s periodic
for _, job := range c.AllPeriodics() {
if job.Cluster == "security" {
t.Fatalf("Jobs not in kubernetes-security/* should not use the security cluster! %s", job.Name)
}
}
}
// checkDockerSocketVolumes returns an error if any volume uses a hostpath
// to the docker socket. we do not want to allow this
func checkDockerSocketVolumes(volumes []coreapi.Volume) error {
for _, volume := range volumes {
if volume.HostPath != nil && volume.HostPath.Path == "/var/run/docker.sock" {
return errors.New("job uses HostPath with docker socket")
}
}
return nil
}
// Make sure jobs are not using the docker socket as a host path
func TestJobDoesNotHaveDockerSocket(t *testing.T) {
for _, presubmit := range c.AllStaticPresubmits(nil) {
if presubmit.Spec != nil {
if err := checkDockerSocketVolumes(presubmit.Spec.Volumes); err != nil {
t.Errorf("Error in presubmit: %v", err)
}
}
}
for _, postsubmit := range c.AllStaticPostsubmits(nil) {
if postsubmit.Spec != nil {
if err := checkDockerSocketVolumes(postsubmit.Spec.Volumes); err != nil {
t.Errorf("Error in postsubmit: %v", err)
}
}
}
for _, periodic := range c.Periodics {
if periodic.Spec != nil {
if err := checkDockerSocketVolumes(periodic.Spec.Volumes); err != nil {
t.Errorf("Error in periodic: %v", err)
}
}
}
}
// checkLatestUsesImagePullPolicy returns an error if an image is a `latest-.*` tag,
// but doesn't have imagePullPolicy: Always
func checkLatestUsesImagePullPolicy(spec *coreapi.PodSpec) error {
for _, container := range spec.Containers {
if strings.Contains(container.Image, ":latest-") {
// If the job doesn't specify imagePullPolicy: Always,
// we aren't guaranteed to check for the latest version of the image.
if container.ImagePullPolicy != "Always" {
return errors.New("job uses latest- tag, but does not specify imagePullPolicy: Always")
}
}
if strings.HasSuffix(container.Image, ":latest") {
// The k8s default for `:latest` images is `imagePullPolicy: Always`
// Check the job didn't override
if container.ImagePullPolicy != "" && container.ImagePullPolicy != "Always" {
return errors.New("job uses latest tag, but does not specify imagePullPolicy: Always")
}
}
}
return nil
}
// Make sure jobs that use `latest-*` tags specify `imagePullPolicy: Always`
func TestLatestUsesImagePullPolicy(t *testing.T) {
for _, presubmit := range c.AllStaticPresubmits(nil) {
if presubmit.Spec != nil {
if err := checkLatestUsesImagePullPolicy(presubmit.Spec); err != nil {
t.Errorf("Error in presubmit %q: %v", presubmit.Name, err)
}
}
}
for _, postsubmit := range c.AllStaticPostsubmits(nil) {
if postsubmit.Spec != nil {
if err := checkLatestUsesImagePullPolicy(postsubmit.Spec); err != nil {
t.Errorf("Error in postsubmit %q: %v", postsubmit.Name, err)
}
}
}
for _, periodic := range c.AllPeriodics() {
if periodic.Spec != nil {
if err := checkLatestUsesImagePullPolicy(periodic.Spec); err != nil {
t.Errorf("Error in periodic %q: %v", periodic.Name, err)
}
}
}
}
// checkKubekinsPresets returns an error if a spec references to kubekins-e2e|bootstrap image,
// but doesn't use service preset or ssh preset
func checkKubekinsPresets(jobName string, spec *coreapi.PodSpec, labels map[string]string, validLabels map[string]bool) error {
service := true
ssh := true
for _, container := range spec.Containers {
if strings.Contains(container.Image, "kubekins-e2e") || strings.Contains(container.Image, "bootstrap") {
service = false
for key, val := range labels {
if key == "preset-service-account" && val == "true" {
service = true
}
}
}
scenario := ""
for _, arg := range container.Args {
if strings.HasPrefix(arg, "--scenario=") {
scenario = strings.TrimPrefix(arg, "--scenario=")
}
}
if scenario == "kubenetes_e2e" {
ssh = false
for key, val := range labels {
if (key == "preset-k8s-ssh" || key == "preset-aws-ssh") && val == "true" {
ssh = true
}
}
}
}
if !service {
return fmt.Errorf("cannot find service account preset")
}
if !ssh {
return fmt.Errorf("cannot find ssh preset")
}
for key, val := range labels {
pair := key + ":" + val
if validVal, ok := validLabels[pair]; !ok || !validVal {
return fmt.Errorf("key-value pair %s is not found in list of valid presets list", pair)
}
}
return nil
}
// TestValidPresets makes sure all presets name starts with 'preset-', all job presets are valid,
// and jobs that uses kubekins-e2e image has the right service account preset
func TestValidPresets(t *testing.T) {
validLabels := map[string]bool{}
for _, preset := range c.Presets {
for label, val := range preset.Labels {
if !strings.HasPrefix(label, "preset-") {
t.Errorf("Preset label %s - label name should start with 'preset-'", label)
}
pair := label + ":" + val
if _, ok := validLabels[pair]; ok {
t.Errorf("Duplicated preset 'label:value' pair : %s", pair)
} else {
validLabels[pair] = true
}
}
}
if !*k8sProw {
return
}
for _, presubmit := range c.AllStaticPresubmits(nil) {
if presubmit.Spec != nil && !cfg.ShouldDecorate(&c.JobConfig, presubmit.JobBase.UtilityConfig) {
if err := checkKubekinsPresets(presubmit.Name, presubmit.Spec, presubmit.Labels, validLabels); err != nil {
t.Errorf("Error in presubmit %q: %v", presubmit.Name, err)
}
}
}
for _, postsubmit := range c.AllStaticPostsubmits(nil) {
if postsubmit.Spec != nil && !cfg.ShouldDecorate(&c.JobConfig, postsubmit.JobBase.UtilityConfig) {
if err := checkKubekinsPresets(postsubmit.Name, postsubmit.Spec, postsubmit.Labels, validLabels); err != nil {
t.Errorf("Error in postsubmit %q: %v", postsubmit.Name, err)
}
}
}
for _, periodic := range c.AllPeriodics() {
if periodic.Spec != nil && !cfg.ShouldDecorate(&c.JobConfig, periodic.JobBase.UtilityConfig) {
if err := checkKubekinsPresets(periodic.Name, periodic.Spec, periodic.Labels, validLabels); err != nil {
t.Errorf("Error in periodic %q: %v", periodic.Name, err)
}
}
}
}
func hasArg(wanted string, args []string) bool {
for _, arg := range args {
if strings.HasPrefix(arg, wanted) {
return true
}
}
return false
}
func checkScenarioArgs(jobName, imageName string, args []string) error {
// env files/scenarios validation
scenarioArgs := false
scenario := ""
for _, arg := range args {
if strings.HasPrefix(arg, "--env-file=") {
return fmt.Errorf("job %s: --env-file is deprecated, please migrate to presets %s", jobName, arg)
}
if arg == "--" {
scenarioArgs = true
}
if strings.HasPrefix(arg, "--scenario=") {
scenario = strings.TrimPrefix(arg, "--scenario=")
}
}
if scenario == "" {
if !scenarioArgs {
if strings.Contains(imageName, "kubekins-e2e") ||
strings.Contains(imageName, "bootstrap") ||
strings.Contains(imageName, "gcloud-in-go") {
return fmt.Errorf("job %s: image %s uses bootstrap.py and need scenario args", jobName, imageName)
}
return nil
}
} else {
if _, err := os.Stat(fmt.Sprintf("../../../scenarios/%s.py", scenario)); err != nil {
return fmt.Errorf("job %s: scenario %s does not exist: %s", jobName, scenario, err)
}
if !scenarioArgs {
return fmt.Errorf("job %s: set --scenario=%s and will need scenario args", jobName, scenario)
}
}
// shared build args
useSharedBuildInArgs := hasArg("--use-shared-build", args)
extractInArgs := hasArg("--extract", args)
buildInArgs := hasArg("--build", args)
if useSharedBuildInArgs && extractInArgs {
return fmt.Errorf("job %s: --use-shared-build and --extract cannot be combined", jobName)
}
if useSharedBuildInArgs && buildInArgs {
return fmt.Errorf("job %s: --use-shared-build and --build cannot be combined", jobName)
}
if scenario != "kubernetes_e2e" {
return nil
}
if hasArg("--provider=gke", args) {
if !hasArg("--deployment=gke", args) {
return fmt.Errorf("with --provider=gke, job %s must use --deployment=gke", jobName)
}
if hasArg("--gcp-master-image", args) {
return fmt.Errorf("with --provider=gke, job %s cannot use --gcp-master-image", jobName)
}
if hasArg("--gcp-nodes", args) {
return fmt.Errorf("with --provider=gke, job %s cannot use --gcp-nodes", jobName)
}
}
if hasArg("--deployment=gke", args) && !hasArg("--gcp-node-image", args) {
return fmt.Errorf("with --deployment=gke, job %s must use --gcp-node-image", jobName)
}
if hasArg("--stage=gs://kubernetes-release-pull", args) && hasArg("--check-leaked-resources", args) {
return fmt.Errorf("presubmit job %s should not check for resource leaks", jobName)
}
extracts := hasArg("--extract=", args)
sharedBuilds := hasArg("--use-shared-build", args)
nodeE2e := hasArg("--deployment=node", args)
builds := hasArg("--build", args)
if sharedBuilds && extracts {
return fmt.Errorf("e2e jobs %s cannot have --use-shared-build and --extract", jobName)
}
if !sharedBuilds && !extracts && !nodeE2e && !builds {
return fmt.Errorf("e2e jobs %s should get k8s build from one of --extract, --use-shared-build, --build or use --deployment=node", jobName)
}
expectedExtract := 1
if sharedBuilds || nodeE2e {
expectedExtract = 0
} else if builds && !extracts {
expectedExtract = 0
} else if strings.Contains(jobName, "ingress") {
expectedExtract = 1
} else if strings.Contains(jobName, "upgrade") ||
strings.Contains(jobName, "skew") ||
strings.Contains(jobName, "rollback") ||
strings.Contains(jobName, "downgrade") ||
jobName == "ci-kubernetes-e2e-gce-canary" {
expectedExtract = 2
}
numExtract := 0
for _, arg := range args {
if strings.HasPrefix(arg, "--extract=") {
numExtract++
}
}
if numExtract != expectedExtract {
return fmt.Errorf("e2e jobs %s should have %d --extract flags, got %d", jobName, expectedExtract, numExtract)
}
if hasArg("--image-family", args) != hasArg("--image-project", args) {
return fmt.Errorf("e2e jobs %s should have both --image-family and --image-project, or none of them", jobName)
}
// test_args should not have double slashes on ginkgo flags
for _, arg := range args {
ginkgoArgs := ""
if strings.HasPrefix(arg, "--test_args=") {
split := strings.SplitN(arg, "=", 2)
ginkgoArgs = split[1]
} else if strings.HasPrefix(arg, "--upgrade_args=") {
split := strings.SplitN(arg, "=", 2)
ginkgoArgs = split[1]
}
if strings.Contains(ginkgoArgs, "\\\\") {
return fmt.Errorf("jobs %s - double slashes in ginkgo args should be single slash now : arg %s", jobName, arg)
}
}
// timeout should be valid
bootstrapTimeout := 0 * time.Minute
kubetestTimeout := 0 * time.Minute
var err error
kubetest := false
for _, arg := range args {
if strings.HasPrefix(arg, "--timeout=") {
timeout := strings.SplitN(arg, "=", 2)[1]
if kubetest {
if kubetestTimeout, err = time.ParseDuration(timeout); err != nil {
return fmt.Errorf("jobs %s - invalid kubetest timeout : arg %s", jobName, arg)
}
} else {
if bootstrapTimeout, err = time.ParseDuration(timeout + "m"); err != nil {
return fmt.Errorf("jobs %s - invalid bootstrap timeout : arg %s", jobName, arg)
}
}
}
if arg == "--" {
kubetest = true
}
}
if bootstrapTimeout.Minutes()-kubetestTimeout.Minutes() < 20.0 {
return fmt.Errorf(
"jobs %s - kubetest timeout(%v), bootstrap timeout(%v): bootstrap timeout need to be 20min more than kubetest timeout!", jobName, kubetestTimeout, bootstrapTimeout)
}
return nil
}
// TestValidScenarioArgs makes sure all scenario args in job configs are valid
func TestValidScenarioArgs(t *testing.T) {
for _, job := range c.AllStaticPresubmits(nil) {
if job.Spec != nil && !cfg.ShouldDecorate(&c.JobConfig, job.JobBase.UtilityConfig) {
if err := checkScenarioArgs(job.Name, job.Spec.Containers[0].Image, job.Spec.Containers[0].Args); err != nil {
t.Errorf("Invalid Scenario Args : %s", err)
}
}
}
for _, job := range c.AllStaticPostsubmits(nil) {
if job.Spec != nil && !cfg.ShouldDecorate(&c.JobConfig, job.JobBase.UtilityConfig) {
if err := checkScenarioArgs(job.Name, job.Spec.Containers[0].Image, job.Spec.Containers[0].Args); err != nil {
t.Errorf("Invalid Scenario Args : %s", err)
}
}
}
for _, job := range c.AllPeriodics() {
if job.Spec != nil && !cfg.ShouldDecorate(&c.JobConfig, job.JobBase.UtilityConfig) {
if err := checkScenarioArgs(job.Name, job.Spec.Containers[0].Image, job.Spec.Containers[0].Args); err != nil {
t.Errorf("Invalid Scenario Args : %s", err)
}
}
}
}
func allStaticJobs() []cfg.JobBase {
jobs := []cfg.JobBase{}
for _, job := range c.AllStaticPresubmits(nil) {
jobs = append(jobs, job.JobBase)
}
for _, job := range c.AllStaticPostsubmits(nil) {
jobs = append(jobs, job.JobBase)
}
for _, job := range c.AllPeriodics() {
jobs = append(jobs, job.JobBase)
}
sort.Slice(jobs, func(i, j int) bool {
return jobs[i].Name < jobs[j].Name
})
return jobs
}
func verifyPodQOSGuaranteed(spec *coreapi.PodSpec) (errs []error) {
resourceNames := []coreapi.ResourceName{
coreapi.ResourceCPU,
coreapi.ResourceMemory,
}
zero := resource.MustParse("0")
for _, c := range spec.Containers {
for _, r := range resourceNames {
limit, ok := c.Resources.Limits[r]
if !ok {
errs = append(errs, fmt.Errorf("container '%v' should have resources.limits[%v] specified", c.Name, r))
}
request, ok := c.Resources.Requests[r]
if !ok {
errs = append(errs, fmt.Errorf("container '%v' should have resources.requests[%v] specified", c.Name, r))
}
if limit.Cmp(zero) == 0 {
errs = append(errs, fmt.Errorf("container '%v' resources.limits[%v] should be non-zero", c.Name, r))
} else if limit.Cmp(request) != 0 {
errs = append(errs, fmt.Errorf("container '%v' resources.limits[%v] (%v) should match request (%v)", c.Name, r, limit.String(), request.String()))
}
}
}
return errs
}
// A job is merge-blocking if it:
// - is not optional
// - reports (aka does not skip reporting)
// - always runs OR runs if some path changed
func isMergeBlocking(job cfg.Presubmit) bool {
return !job.Optional && !job.SkipReport && (job.AlwaysRun || job.RunIfChanged != "")
}
func isKubernetesReleaseBlocking(job cfg.JobBase) bool {
re := regexp.MustCompile(`sig-release-(1.[0-9]{2}|master)-blocking`)
dashboards, ok := job.Annotations["testgrid-dashboards"]
if !ok {
return false
}
return re.MatchString(dashboards)
}
func TestKubernetesMergeBlockingJobsMustHavePodQOSGuaranteed(t *testing.T) {
repo := "kubernetes/kubernetes"
jobs := c.AllStaticPresubmits([]string{repo})
sort.Slice(jobs, func(i, j int) bool {
return jobs[i].Name < jobs[j].Name
})
for _, job := range jobs {
// Only consider Pods that are merge-blocking
if job.Spec == nil || !isMergeBlocking(job) {
continue
}
branches := job.Branches