-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new maintainers to CAPC repo #3528
Conversation
Welcome @maxdrib! |
Hi @maxdrib. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
/ok-to-test |
Both @maxdrib and @rejoshed are in the OWNERS https://github.com/kubernetes-sigs/cluster-api-provider-cloudstack/blob/main/OWNERS |
/lgtm |
/approve |
/lgtm |
ping @vincepri can you review and advise on this PR? Thanks. |
Bump @vincepri would you please take a look? |
ping @fabriziopandini @neolit123, Can you please take a look at this since you both are also listed as approvers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maxdrib, neolit123, rohityadavcloud The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maxdrib, neolit123, rohityadavcloud The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In order to help unblock development and release of the CAPC repository, we would like to add a few more maintainers to the CAPC repo to have the ability to create branches and tags. These individuals are already listed in the OWNERS file in CAPC: https://github.com/kubernetes-sigs/cluster-api-provider-cloudstack/blob/main/OWNERS