Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new repo: kubernetes-csi/csi-driver-image-populator #486

Closed
kfox1111 opened this issue Feb 14, 2019 · 15 comments
Closed

new repo: kubernetes-csi/csi-driver-image-populator #486

kfox1111 opened this issue Feb 14, 2019 · 15 comments
Assignees
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository

Comments

@kfox1111
Copy link
Contributor

kfox1111 commented Feb 14, 2019

New Repo, Staging Repo, or migrate existing

new repository

Requested name for new repository

csi-driver-image-populator

Which Organization should it reside

kubernetes-csi

If not a staging repo, who should have admin access

@saad-ali @msau42

If not a staging repo, who should have write access

@saad-ali @msau42

If a new repo, who should be listed as approvers in OWNERS

@saad-ali @msau42 @kfox1111

If a new repo, who should be listed in SECURITY_CONTACTS

@saad-ali @msau42 @kfox1111

What should the repo description be

CSI driver that uses a container image as a volume

What SIG and subproject does this fall under in sigs.yaml

part of the CSI working group in SIG-storage

Approvals

Discussed and approved on Thursday, Feb 14, 2019, in the sig-storage meeting
Also discussed on the sig-storage group:
https://groups.google.com/forum/#!topic/kubernetes-sig-storage/6_SpwBiaNtI

@kfox1111 kfox1111 added the area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository label Feb 14, 2019
@spiffxp
Copy link
Member

spiffxp commented Feb 19, 2019

/assign @nikhita
Please give this one a shot

@msau42
Copy link
Member

msau42 commented Feb 20, 2019

csi-driver-image is a confusing name and it might be interpreted to mean something related to storing container images for the drivers we maintain.

I can't really think of something much better. How about something like:
csi-driver-image-volume
csi-driver-container-image-volume

@kfox1111
Copy link
Contributor Author

all the storage drivers are under csi-driver-X. so I think csi-driver-image makes sense. But I'm open to either of the other two as well. all of them make sense in one way or the other.

(There are 2 hard problems in computer science. naming things, cache invalidation, and off by one errors 😄 )

@kfox1111
Copy link
Contributor Author

Are we stuck on naming? Who can pick?

@msau42
Copy link
Member

msau42 commented Feb 20, 2019

@saad-ali and I brainstormed and came up with:
csi-driver-image-populator

wdyt?

@kfox1111
Copy link
Contributor Author

wfm

@kfox1111
Copy link
Contributor Author

Do I need to amend the request?

@msau42
Copy link
Member

msau42 commented Feb 21, 2019

Sure go ahead and edit the first comment with the updated name

@kfox1111 kfox1111 changed the title new repo: kubernetes-csi/csi-driver-image new repo: kubernetes-csi/csi-driver-image-populator Feb 21, 2019
@kfox1111
Copy link
Contributor Author

✔️

@msau42
Copy link
Member

msau42 commented Feb 21, 2019

/lgtm

@nikhita
Copy link
Member

nikhita commented Feb 22, 2019

Created https://github.com/kubernetes-csi/csi-driver-image-populator 🎉

I have also created two PRs:

Once #517 has merged and the postsubmit has run, the new GitHub teams will be created. I'll manually update the collaborators to the repo to provide access to the teams once that's done. :)


@kfox1111 I have added you as an approver for the repo, but to be able to use these approval powers, you need to be a member of @kubernetes-csi. Can you please file a membership request for this?

@nikhita
Copy link
Member

nikhita commented Feb 22, 2019

The new GitHub teams have been created and I have updated repo permissions.

csi-driver-image-populator-admins has admin access and csi-driver-image-populator-maintainers has write access.

I'll close this issue once kubernetes/community#3293 is merged.

@kfox1111
Copy link
Contributor Author

Ok. I'll file a membership request asap.

Thanks everyone for all the help. :)

@nikhita
Copy link
Member

nikhita commented Feb 22, 2019

kubernetes/community#3293 has merged. Closing this issue.

/close

@k8s-ci-robot
Copy link
Contributor

@nikhita: Closing this issue.

In response to this:

kubernetes/community#3293 has merged. Closing this issue.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository
Projects
None yet
Development

No branches or pull requests

5 participants