Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: Migrate telekom/cluster-api-ipam-provider-in-cluster to kubernetes-sigs #4204

Closed
schrej opened this issue May 9, 2023 · 11 comments
Closed
Assignees
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.

Comments

@schrej
Copy link
Member

schrej commented May 9, 2023

New repo, staging repo, or migrate existing

Migrate https://github.com/telekom/cluster-api-ipam-provider-in-cluster

Is it a staging repo?

no

Requested name for new repository

cluster-api-ipam-provider-in-cluster

Which Organization should it reside

kubernetes-sigs

Who should have admin access?

@CecileRobertMichon @fabriziopandini @schrej

Who should have write access?

No response

Who should be listed as approvers in OWNERS?

@schrej @srm09

Who should be listed in SECURITY_CONTACTS?

@fabriziopandini @CecileRobertMichon @schrej

What should the repo description be?

A Cluster API IPAM provider that manages addresses as resources in-cluster.

What SIG and subproject does this fall under?

sig-cluster-lifecycle

Please provide references to appropriate approval for this new repo

kubernetes-sigs/cluster-api-ipam-provider-in-cluster#110
This issue also contains a checklist with all the preparation tasks required for the move as listed in the documentation.

Additional context for request

We have additional approvers lined up, but they'll need to join kubernetes-sigs first.

@CecileRobertMichon @fabriziopandini would you like approver access as well? I would skip it to avoid unnecessary assignments. (Is there a way to have "passive" approvers to provide SIG leads permissions without getting them assigned automatically?)

@schrej schrej added the area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository label May 9, 2023
@fabriziopandini
Copy link
Member

/lgtm

@CecileRobertMichon @fabriziopandini would you like approver access as well?

I'm ok following the same approach used by other providers (I consider notification only if directly mentioned, otherwise I defer to the project team)

@CecileRobertMichon
Copy link
Member

CecileRobertMichon commented May 9, 2023

/lgtm

otherwise I defer to the project team

@schrej are there any additional reviewers/OWNERs besides yourself? I don't think either myself or @fabriziopandini (I'll let Fabrizio speak for himself though) have the bandwidth to 1) review every single PR, or 2) take over the project if you were to step away from it

Rather than adding us both as individual approvers, I would recommend adding a "group" of owners as admins/approvers (such as CAPI approvers or admins), in addition to the approvers for the IPAM provider (for now sounds like it's just you).

@christianang
Copy link

We did have some discussion in kubernetes-sigs/cluster-api-ipam-provider-in-cluster#128 about adding @tylerschultz and @srm09 as approvers. Tyler I believe would need approval to be a member, but I can ask him to open an issue to get membership if that is the correct next step.

@schrej
Copy link
Member Author

schrej commented May 10, 2023

@christianang he'll need sponsors from two different companies and needs to be able to show some contributions to Kubernetes projects (this one probably doesn't count yet), then he can open an issue.

I don't think either myself or @fabriziopandini have the bandwidth to 1) review every single PR

@CecileRobertMichon that's what I thought. Ideally I'd like to add you as passive approvers so you can approve as technical sig leads, but don't get suggested by the bot. But I don't think thats an option at the moment.

I would suggest to discuss approvers outside of this issue. The plan is to increase them to at least 2-3 people, but we can take care of that after the move. We shouldn't have an issue finding enough people.

@srm09
Copy link
Contributor

srm09 commented May 11, 2023

Awesome to see this move finally happen, thanks for leading the way @schrej
I agree to have Tyler added as an approver, in the meantime Jakob and I could do the work of PR approval and have Tyler add in passive reviews on any PRs issued.

@nikhita
Copy link
Member

nikhita commented May 24, 2023

@CecileRobertMichon @fabriziopandini let us know when you are good with proceeding with the repo transfer and we'll work out next steps.

@nikhita nikhita added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label May 24, 2023
schrej added a commit to kubernetes-sigs/cluster-api-ipam-provider-in-cluster that referenced this issue May 24, 2023
@CecileRobertMichon
Copy link
Member

I agree to have Tyler added as an approver, in the meantime Jakob and I could do the work of PR approval and have Tyler add in passive reviews on any PRs issued.

SGTM

@nikhita we are good to proceed

@nikhita nikhita self-assigned this May 25, 2023
@fabriziopandini
Copy link
Member

+1 from me!

@mrbobbytables
Copy link
Member

/assign

@mrbobbytables
Copy link
Member

Repo has been migrated, teams added and info added to k/community. I'm going to go ahead and close this out, if there are additional issues/questions please don't hesitate to reach out.

Thanks!

/close

@k8s-ci-robot
Copy link
Contributor

@mrbobbytables: Closing this issue.

In response to this:

Repo has been migrated, teams added and info added to k/community. I'm going to go ahead and close this out, if there are additional issues/questions please don't hesitate to reach out.

Thanks!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Development

No branches or pull requests

8 participants