-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade kubernetes dashboard to v2.1.0 for 1.20 #9963
Conversation
Now with support for Kubernetes version 1.20 too
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This will probably affect the preload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think this will just require a bump in preload version so that the new image is included:
minikube/pkg/minikube/download/preload.go
Line 44 in c909561
PreloadVersion = "v7" |
And the bump is done just before generating the release preload, right ? |
Yup, once the PR is merged then the release will kick off |
@priyawadhwa : my question was actually if it should be included in this commit Or if there will be a separate preload version bump, later on ? (in the release process) |
Ah, sorry! I think it's fine to include it in this PR. |
Now with support for Kubernetes version 1.20 too
https://github.com/kubernetes/dashboard/releases/tag/v2.1.0