Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start: Support comma-delimited --addons #9957

Merged
merged 1 commit into from
Dec 14, 2020
Merged

start: Support comma-delimited --addons #9957

merged 1 commit into from
Dec 14, 2020

Conversation

Aut0R3V
Copy link
Contributor

@Aut0R3V Aut0R3V commented Dec 14, 2020 •
edited by tstromberg
Loading

Fixes #9319

Using slicing technique in the place of an Array for line 141.

@Aut0R3V
Update start_flags.go
375d25d 
Using slicing technique in the place of an Array for line 141.
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 14, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Aut0R3V. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 14, 2020
@Aut0R3V
Copy link
Contributor Author

Aut0R3V commented Dec 14, 2020

@josedonizetti

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@bl-ue
Copy link

bl-ue commented Dec 14, 2020

@Aut0R3V the bot (@k8s-ci-robot) doesn't like you to put the issue number in the PR title. You should put it in the description instead.

@tstromberg tstromberg changed the title Update start_flags.go "fixes #9319" start: Support comma-delimited --addons Dec 14, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 14, 2020
tstromberg
tstromberg approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew, that was easy. Thank you!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Aut0R3V, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2020
@tstromberg tstromberg merged commit f71e525 into kubernetes:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

start: Comma-delimited --addons silently ignored
5 participants
@Aut0R3V @k8s-ci-robot @minikube-bot @bl-ue @tstromberg