Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

machine: add parallels support #953

Merged
merged 1 commit into from
Feb 8, 2019
Merged

machine: add parallels support #953

merged 1 commit into from
Feb 8, 2019

Conversation

denji
Copy link
Contributor

@denji denji commented Dec 31, 2016

xhyve will not work on older iMac, CPU core the presence of support VT-d will not help. Paralells works along with VMware Fusion.

  1. xhyve will not working without the Hypervisor.framework.
  2. Hypervisor.framework will not working VT-x without (EPT & Unrestricted Mode)

Hypervisor.framework

Generally, machines with an Intel VT-x feature set that includes Extended Page Tables (EPT) and Unrestricted Mode are supported. You can determine the availability of Hypervisor APIs on a particular machine at runtime with the sysctl(8) command, passing kern.hv_support as an argument.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 31, 2016
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

1 similar comment
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented Dec 31, 2016

Current coverage is 34.81% (diff: 0.00%)

Merging #953 into master will decrease coverage by 0.07%

@@             master       #953   diff @@
==========================================
  Files            43         43          
  Lines          1978       1982     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            690        690          
- Misses         1152       1156     +4   
  Partials        136        136          

Powered by Codecov. Last update e52833a...cd00210

@denji
Copy link
Contributor Author

denji commented Dec 31, 2016

I signed it!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 31, 2016
@dlorenc
Copy link
Contributor

dlorenc commented Dec 31, 2016

@minikube-bot test this please

@dlorenc
Copy link
Contributor

dlorenc commented Dec 31, 2016

@minikube-bot ok to test

@dlorenc
Copy link
Contributor

dlorenc commented Jan 3, 2017

Thanks for the PR. We're trying to keep our test matrix low by only supporting a few virtualization systems per platform, but we have had quite a few requests for parallels. Would you mind explaining the benefits of parallels over xhyve? That's where we've been spending most of our time.

@denji
Copy link
Contributor Author

denji commented Jan 3, 2017

It's very simple: xhyve will not work on older iMac, CPU core the presence of support VT-d will not help. Paralells works along with VMware Fusion.

  1. xhyve will not working without the Hypervisor.framework.
  2. Hypervisor.framework will not working VT-x without (EPT & Unrestricted Mode)

Hypervisor.framework

Generally, machines with an Intel VT-x feature set that includes Extended Page Tables (EPT) and Unrestricted Mode are supported. You can determine the availability of Hypervisor APIs on a particular machine at runtime with the sysctl(8) command, passing kern.hv_support as an argument.
$ sysctl kern.hv_support
kern.hv_support: 0
cihofukweaysflj

@cblecker
Copy link
Member

I agree with @denji 's points and assessment of the advantages, and would definitely support inclusion of a parallels provider.

@uoryon
Copy link

uoryon commented Mar 29, 2017

I would definitely support inclusion of a parallels provider, too. And why this pr not proceed to deal with?

@ivanfioravanti
Copy link

Any news on this one? Parallels is supported and works very well on Docker-Machine, why shouldn't you include it?

@cadavre
Copy link

cadavre commented Aug 17, 2017

Bringing this up with +1.

Would you mind explaining the benefits of parallels over xhyve?

I'm not quite aware of any benefits, but you – team Minikube – shall consider one: if someone is already using Parallels for their needs, why one should install another vm if supporting Parallels is so simple according to this PR's commit diff?

@troyfontaine
Copy link

It looks like the XHYVE driver overrides the Docker for Mac docker-machine, so if you also still want to use the Docker provided version you may have some hoops to jump through in that regard. With how small of a change it is to support it, is it that bad of a trade off?

@SailingYYC
Copy link

+1, Parallels is a performant and supported virtualization platform on Mac. xhyve doesn't seem nearly as stable as Docker's implementation of hypervisor.framework.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 10, 2018
@troyfontaine
Copy link

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 10, 2018
@rhooper
Copy link

rhooper commented Mar 23, 2018

I'm another person that would really like to see parallels support added into minikube.
I really dislike having more than one hypervisor running, as I've run into random networking, hangs, and performance issues when using multiple hypervisors.

@bassam
Copy link
Contributor

bassam commented Apr 20, 2018

+1 for parallels support. If the issue is keeping the test matrix small, then merge this PR and mark parallels support experimental or unsupported.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 19, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 18, 2018
@cadavre
Copy link

cadavre commented Aug 19, 2018

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 19, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2018
@troyfontaine
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2018
@tstromberg
Copy link
Contributor

mind addressing the merge conflicts? I'd like to see about getting this included as an experimental driver (meaning: not initially covered by our CI)

@RA489
Copy link

RA489 commented Jan 18, 2019

@denji This PR needs rebase. Also Please look at the failing tests.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: denji
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tstromberg

If they are not already assigned, you can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pkg/minikube/cluster/cluster.go Outdated Show resolved Hide resolved
pkg/minikube/cluster/default_drivers.go Outdated Show resolved Hide resolved
@tstromberg tstromberg merged commit 6e1b9d0 into kubernetes:master Feb 8, 2019
@tstromberg
Copy link
Contributor

tstromberg commented Feb 8, 2019

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.