add --watch flag for minikube status with optional interval duration #9487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @prezha. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/M
Travis tests have failedHey @prezha, 1st Buildmake testTravisBuddy Request Identifier: 6a745c80-1187-11eb-bfd1-1f84b849c73d |
|
Can one of the admins verify this patch? |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
kvm2 Driver |
medyagh
requested changes
Oct 26, 2020
cmd/minikube/cmd/status.go
Outdated
| if !watch { | ||
| os.Exit(exitCode(statuses)) | ||
| } | ||
| time.Sleep(1 * time.Second) |
There was a problem hiding this comment.
how about making this configureable ?
like --watch-interval with a default value of 1 second?
There was a problem hiding this comment.
like the idea!
and instead of adding a separate flag, would we want just to expand the --watch flag to also support an optional value (defaulting to 1 sec)? ie
-w, --watch duration[=1s] Continuously listing/getting the status with optional interval duration. (default 1s)
so, eg, -w=5s would sleep for 5 sec between consecutive polls
i've made changes to the pr according to this proposal - please have a look and share your thoughts
k8s-ci-robot
added
size/L
|
kvm2 Driver Times for Minikube (PR 9487): 60.4s 61.5s 59.9s Averages Time Per Log docker Driver Times for Minikube (PR 9487): 28.8s 28.1s 28.5s Averages Time Per Log |
priyawadhwa
reviewed
Nov 5, 2020
priyawadhwa
reviewed
Nov 5, 2020
cmd/minikube/cmd/status.go
Outdated
| @@ -203,59 +204,63 @@ var statusCmd = &cobra.Command{ | |||
| cname := ClusterFlagValue() | |||
| api, cc := mustload.Partial(cname) | |||
|
|
|||
| var statuses []*Status | |||
| for { | |||
| var statuses []*Status | |||
There was a problem hiding this comment.
Could you move all of the code in the for loop into a separate function? That would make this more readable.
There was a problem hiding this comment.
@priyawadhwa i've moved the code to a separate func writeStatusesAtInterval, please have a look
@priyawadhwa thank you for your comment - would you say that the proposal above is in line with that or you think it should be a separate flag? |
|
@prezha yes, I agree with your proposal. If something like, |
yes, that is the idea, thank you for confirming |
k8s-ci-robot
added
size/M
|
kvm2 Driver Times for Minikube (PR 9487): 55.6s 54.1s 53.6s Averages Time Per Log docker Driver Times for Minikube (PR 9487): 26.7s 27.5s 27.2s Averages Time Per Log |
prezha
changed the title
k8s-ci-robot
added
the
needs-rebase
prezha
force-pushed
the
status-add-watch-flag
branch
from
b6c384e
to
58dbc5c
Compare
k8s-ci-robot
removed
the
needs-rebase
Travis tests have failedHey @prezha, 1st Buildmake testTravisBuddy Request Identifier: cca02ca0-2158-11eb-a04c-b76cbd6ddda3 |
prezha
force-pushed
the
status-add-watch-flag
branch
from
58dbc5c
to
7cc4676
Compare
medyagh
reviewed
Nov 11, 2020
|
thanks @medyagh for your review and |
medyagh
approved these changes
Nov 11, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, prezha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #9468
add
minikube status --watch[=duration](-w) flag that will produce continuous output waiting for a specified duration (defaulting to 1 sec) between each pollexample output