add dedicated network for docker driver #9294

medyagh · 2020-09-22T00:28:52Z

redoing this PR:
https://github.com/kubernetes/minikube/pull/9094/files

After this PR

Create one network per Cluster
Assign Static IP based on the machine order (offset from gateway)
if can't create network becaue subnet is taken, bump the subnet 3rd octet by 10, and try again.
add more error types
add failfast error type for not trying again with same IP, when error is IP is in use.
add created_by_minikube=true label to the networks we create for better clean up. and avoid deleting user's networks.
closes docker: minikube delete should delete the network #9087
closes docker network create : Pool overlaps with other one on this address space #9069
closes docker: start fails on storage provisioner addon "x509: certificate is valid for 172.17.0.3" #8936

TODO: verify it wont break upgrade running binary test

here is the link to the binary from a PR
http://storage.googleapis.com/minikube-builds/9294/minikube-linux-amd64

k8s-ci-robot · 2020-09-22T00:29:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TravisBuddy · 2020-09-22T00:37:31Z

Travis tests have failed

Hey @medyagh,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.13.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.13.1 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="3bec0e83d64cc685f8abd26b671e160c359ea7dc" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v3" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.30.0'
golangci/golangci-lint info found version: 1.30.0 for v1.30.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
ok
= go mod ================================================================
unused golang.org/x/exp
ok
= boilerplate ===========================================================
boilerplate missing: /home/travis/gopath/src/github.com/kubernetes/minikube/pkg/drivers/kic/kic_test.go
consider running: /home/travis/gopath/src/github.com/kubernetes/minikube/hack/boilerplate/fix.sh
Makefile:314: recipe for target 'test' failed
make: *** [test] Error 8

TravisBuddy Request Identifier: cb1d0b80-fc6b-11ea-a56a-67316b5b87cd

medyagh · 2020-09-22T00:54:11Z

/ok-to-test

minikube-pr-bot · 2020-09-22T01:00:59Z

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9294): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9294/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9294/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9294): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9294/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9294/minikube: exec format error

minikube-pr-bot · 2020-09-24T03:14:17Z

kvm2 Driver
Times for minikube: 63.0s 62.5s 61.9s
Average time for minikube: 62.5s

Times for Minikube (PR 9294): 62.8s 61.8s 64.0s
Average time for Minikube (PR 9294): 62.9s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9294) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 36.6s    | 35.8s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 23.5s    | 24.5s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.5s     | 1.6s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.7s     | 0.8s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 30.6s 30.4s 31.3s
Average time for minikube: 30.8s

Times for Minikube (PR 9294): 30.5s 30.7s 29.9s
Average time for Minikube (PR 9294): 30.4s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9294) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.2s     | 0.2s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.0s     | 9.1s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 20.2s    | 19.7s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.1s     | 1.1s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.1s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

tstromberg · 2020-09-24T19:21:00Z

Can you update the PR description to describe the problem this attempts to solve and why this PR the best way to go about it?

pkg/drivers/kic/oci/network_create.go

pkg/drivers/kic/kic.go

cmd/minikube/cmd/delete.go

pkg/drivers/kic/kic.go

pkg/drivers/kic/oci/network_create.go

pkg/drivers/kic/oci/types.go

minikube-pr-bot · 2020-09-28T20:05:19Z

kvm2 Driver
Times for minikube: 62.1s 61.2s 60.9s
Average time for minikube: 61.4s

Times for Minikube (PR 9294): 61.3s 59.9s 60.0s
Average time for Minikube (PR 9294): 60.4s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9294) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 36.1s    | 35.9s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 23.5s    | 22.3s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.6s     | 1.6s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.5s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 29.3s 28.3s 27.0s
Average time for minikube: 28.2s

Times for Minikube (PR 9294): 30.4s 30.4s 29.1s
Average time for Minikube (PR 9294): 29.9s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9294) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.2s     | 0.2s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 8.6s     | 8.9s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 18.2s    | 19.6s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 0.9s     | 1.0s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.1s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

priyawadhwa · 2020-09-28T20:11:00Z

Tested this out and it seems to work on Cloud Shell.

tstromberg

Has the updated code been pushed? I see resolved comments with no change in code.

pkg/drivers/kic/kic_test.go

pkg/drivers/kic/kic.go

tstromberg · 2020-09-28T23:54:15Z

pkg/drivers/kic/oci/network_create.go

+		if err != ErrNetworkSubnetTaken {
+			return nil, errors.Wrapf(err, "error creating network")
+		}
+		// try up to 13 times


In case my previous suggestion wasn't good enough, perhaps:

// Rather than iterate through all of the valid subnets, give up at 13 to avoid a lengthy user delay for something that is unlikely to work.

The logic I would have expected here would be an iteration of all the valid subnets within 192.168.0.0/16.

tstromberg · 2020-09-28T23:55:51Z

OK, it seems I was reviewing based on an outdated commit. Taking another look now.

pkg/drivers/kic/oci/errors.go

pkg/drivers/kic/oci/network.go

pkg/drivers/kic/oci/network_create.go

pkg/drivers/kic/oci/types.go

medyagh · 2020-09-29T22:07:53Z

thanks @tstromberg updated the PR with addresing the review comments

minikube-pr-bot · 2020-09-29T22:19:11Z

kvm2 Driver
Times for minikube: 63.1s 64.5s 62.5s
Average time for minikube: 63.3s

Times for Minikube (PR 9294): 61.9s 59.7s 60.1s
Average time for Minikube (PR 9294): 60.6s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9294) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 36.4s    | 35.6s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 24.6s    | 22.7s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.6s     | 1.5s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.8s     | 0.7s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.1s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 29.7s 29.1s 30.1s
Average time for minikube: 29.7s

Times for Minikube (PR 9294): 29.1s 29.4s 31.3s
Average time for Minikube (PR 9294): 29.9s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9294) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.2s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.2s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.0s     | 9.1s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 19.2s    | 19.2s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.0s     | 1.1s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     |                    |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

tstromberg

Would like to see the createDockerNetwork function refactored so that the loop is executed at least once in all cases to make sure it's part of the regular integration tests, but approved otherwise. Thanks!

minikube-pr-bot · 2020-09-30T22:14:11Z

kvm2 Driver
Times for minikube: 65.1s 64.7s 61.9s
Average time for minikube: 63.9s

Times for Minikube (PR 9294): 62.5s 63.9s 66.4s
Average time for Minikube (PR 9294): 64.3s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9294) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 37.8s    | 36.1s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 23.8s    | 25.7s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.7s     | 1.8s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.6s     | 0.5s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 30.7s 28.7s 30.0s
Average time for minikube: 29.8s

Times for Minikube (PR 9294): 31.2s 33.2s 29.6s
Average time for Minikube (PR 9294): 31.3s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9294) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.2s     | 0.2s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.3s     | 9.4s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 18.9s    | 20.3s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.1s     | 1.1s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.1s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.1s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

priyawadhwa

LGTM! Just a few nits

pkg/drivers/kic/kic.go

pkg/drivers/kic/oci/network_create.go

pkg/minikube/driver/driver_test.go

minikube-pr-bot · 2020-09-30T23:55:15Z

kvm2 Driver
Times for minikube: 61.6s 61.1s 64.0s
Average time for minikube: 62.2s

Times for Minikube (PR 9294): 63.4s 62.9s 65.4s
Average time for Minikube (PR 9294): 63.9s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9294) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 36.7s    | 36.9s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 23.2s    | 24.4s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.7s     | 1.7s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.5s     | 0.8s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.5s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 32.6s 30.6s 33.9s
Average time for minikube: 32.4s

Times for Minikube (PR 9294): 32.2s 31.3s 32.6s
Average time for Minikube (PR 9294): 32.1s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9294) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.1 on Debian   | 0.2s     | 0.2s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 10.1s    | 9.8s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 20.0s    | 20.5s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.7s     | 1.3s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.1s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.1s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 22, 2020

k8s-ci-robot requested review from priyawadhwa and tstromberg September 22, 2020 00:29

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2020

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 22, 2020

tstromberg reviewed Sep 24, 2020

View reviewed changes

pkg/drivers/kic/oci/network_create.go Outdated Show resolved Hide resolved

tstromberg suggested changes Sep 24, 2020

View reviewed changes

tstromberg suggested changes Sep 28, 2020

View reviewed changes

tstromberg suggested changes Sep 29, 2020

View reviewed changes

medyagh added 11 commits September 29, 2020 14:14

add network create funcs

9cd4216

first version

f0f10d6

lint

fa0afb2

try alternate if no network

2766235

update with new logic

f163cf9

address review comments

b7780ec

address review comments

058adb7

move index machine to driver package

31e175c

clarify comment

82f39d1

add more unit tests

c48e8e5

address review comments

b84dedc

medyagh requested a review from tstromberg September 29, 2020 22:07

medyagh force-pushed the docker_network branch from cab94ff to b84dedc Compare September 29, 2020 22:07

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2020

tstromberg approved these changes Sep 30, 2020

View reviewed changes

remove kic test

f807bcf

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 30, 2020

priyawadhwa approved these changes Sep 30, 2020

View reviewed changes

pkg/drivers/kic/kic.go Outdated Show resolved Hide resolved

pkg/drivers/kic/oci/network_create.go Outdated Show resolved Hide resolved

pkg/drivers/kic/oci/network_create.go Outdated Show resolved Hide resolved

pkg/minikube/driver/driver_test.go Outdated Show resolved Hide resolved

medyagh changed the title ~~add dedicated Docker network for docker driver~~ add dedicated network for docker driver Sep 30, 2020

address review comments

73d77e2

medyagh mentioned this pull request Sep 30, 2020

pause/suspend/resume/unpause: dial tcp 192.168.39.x:22: connect: no route to host #9328

Closed

medyagh merged commit 0fc0c82 into kubernetes:master Oct 1, 2020

medyagh mentioned this pull request Nov 16, 2020

Add dedicate network and static IP for podman driver #9714

Closed

sharifelgamal mentioned this pull request Jan 26, 2021

Revert static IP for docker #9166

Merged

mconner mentioned this pull request Feb 24, 2021

Add integration test for a VM changing IP and cert not working #10593

Open

medyagh deleted the docker_network branch March 2, 2021 21:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add dedicated network for docker driver #9294

add dedicated network for docker driver #9294

medyagh commented Sep 22, 2020 •

edited

Loading

k8s-ci-robot commented Sep 22, 2020

TravisBuddy commented Sep 22, 2020

medyagh commented Sep 22, 2020

minikube-pr-bot commented Sep 22, 2020

minikube-pr-bot commented Sep 24, 2020

tstromberg commented Sep 24, 2020 •

edited

Loading

minikube-pr-bot commented Sep 28, 2020

priyawadhwa commented Sep 28, 2020

tstromberg left a comment

tstromberg Sep 28, 2020

tstromberg commented Sep 28, 2020

medyagh commented Sep 29, 2020

minikube-pr-bot commented Sep 29, 2020

tstromberg left a comment

minikube-pr-bot commented Sep 30, 2020

priyawadhwa left a comment

minikube-pr-bot commented Sep 30, 2020

add dedicated network for docker driver #9294

add dedicated network for docker driver #9294

Conversation

medyagh commented Sep 22, 2020 • edited Loading

After this PR

k8s-ci-robot commented Sep 22, 2020

TravisBuddy commented Sep 22, 2020

Travis tests have failed

1st Build

TravisBuddy Request Identifier: cb1d0b80-fc6b-11ea-a56a-67316b5b87cd

medyagh commented Sep 22, 2020

minikube-pr-bot commented Sep 22, 2020

minikube-pr-bot commented Sep 24, 2020

tstromberg commented Sep 24, 2020 • edited Loading

minikube-pr-bot commented Sep 28, 2020

priyawadhwa commented Sep 28, 2020

tstromberg left a comment

Choose a reason for hiding this comment

tstromberg Sep 28, 2020

Choose a reason for hiding this comment

tstromberg commented Sep 28, 2020

medyagh commented Sep 29, 2020

minikube-pr-bot commented Sep 29, 2020

tstromberg left a comment

Choose a reason for hiding this comment

minikube-pr-bot commented Sep 30, 2020

priyawadhwa left a comment

Choose a reason for hiding this comment

minikube-pr-bot commented Sep 30, 2020

medyagh commented Sep 22, 2020 •

edited

Loading

tstromberg commented Sep 24, 2020 •

edited

Loading