docker: Improve overlay module check (behavior & UX)

[tstromberg]

Some improvements to the driver performance UX, based on testing in WSL2:

• Fix & simplify built-in overlay module detection (we had forgotten to strip the newline from the kernel version)
• Display suggested performance improvement in a single-line of output again
• Docker for Desktop is now known as Docker Desktop: https://www.docker.com/products/docker-desktop

Old UX

💨  The 'docker' driver reported a performance issue
💡  Suggestion: enable overlayfs kernel module on your Linux

New UX

💨 For improved Docker performance, enable the overlay Linux kernel module using 'modprobe overlay'

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tstromberg]

/ok-to-test

[minikube-pr-bot]

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9163): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9163/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9163/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9163): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9163/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9163/minikube: exec format error

[medyagh]

this PR is removing the Second way of verifying if the first way is failing, which is bad
because on some distros (that I tried) the first way fails but the second way works

path := fmt.Sprintf("/lib/modules/%s/modules.builtin", string(out))

[tstromberg]

It is not removing the second way - it's replacing both with something that will work on all kernels: those with either built-in modules (second check) or pluggable modules (first check)

…

On Wed, Sep 2, 2020 at 12:30 PM Medya Ghazizadeh ***@***.***> wrote: ***@***.**** requested changes on this pull request. this PR is removing the Second way of verifying if the first way is failing, which is bad because on some distros (that I tried) the first way fails but the second way works path := fmt.Sprintf("/lib/modules/%s/modules.builtin", string(out)) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9163 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAYYMHKFD36HGGCIFP2YI3SD2ML7ANCNFSM4QTOQPTA> .