-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start: Add -o shorthand option for --output #9097
start: Add -o shorthand option for --output #9097
Conversation
Hi @vinu2003. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vinu2003 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Travis tests have failedHey @vinu2003, 1st Buildmake test
TravisBuddy Request Identifier: 18628cb0-e7b5-11ea-b1e9-0f855a8df5b8 |
Hey @vinu2003 thanks for fixing this! Whenever changes to flags are made our docs need to be updated as well. You can do this by runninng
The unit tests should pass once you've done that :) |
Hey @priyawadhwa yes. I didnt run make test at all. Noticed now and updtaed the doc by running make-generate-docs. |
3411405
to
1541ca9
Compare
##what
This PR addresses code changes that adds shorthand for start command output option.
Fixes #9088
usage:
before:
after: