docker/podman: add alternative image repo for base image to fallback #7943

medyagh · 2020-04-30T06:09:48Z

This PR adds an alternative image-repo in https://github.com/kubernetes/minikube/packages
for kic base image. instead of gcr.io
fixes: #7472

First: Emulating not having access to GCR:

$ cat /etc/hosts | grep gcr.io
127.0.0.1       gcr.io

$ docker rmi gcr.io/k8s-minikube/kicbase:v0.0.10

Before this PR: time out with ugly error when image not avialble

 $ minikube start --driver=docker
😄  minikube v1.10.0-beta.2 on Darwin 10.15.4
✨  Using the docker driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
E0429 22:29:51.276201   86892 cache.go:122] Error downloading kic artifacts:  getting remote image: Get https://gcr.io/v2/: dial tcp 127.0.0.2:443: i/o timeout
🔥  Creating docker container (CPUs=2, Memory=4000MB) ...
🤦  StartHost failed, but will try again: creating host: create: creating: create kic node: create container: docker run -d -t --privileged --security-opt seccomp=unconfined --security-opt apparmor=unconfined --tmpfs /tmp --tmpfs /run -v /lib/modules:/lib/modules:ro --hostname minikube --name minikube --label created_by.minikube.sigs.k8s.io=true --label name.minikube.sigs.k8s.io=minikube --label role.minikube.sigs.k8s.io= --label mode.minikube.sigs.k8s.io=minikube --volume minikube:/var --cpus=2 --memory=4000mb -e container=docker --expose 8443 --publish=127.0.0.1::8443 --publish=127.0.0.1::22 --publish=127.0.0.1::2376 --publish=127.0.0.1::5000 gcr.io/k8s-minikube/kicbase:v0.0.10@sha256:f58e0c4662bac8a9b5dda7984b185bad8502ade5d9fa364bf2755d636ab51438: exit status 125
stdout:

stderr:
Unable to find image 'gcr.io/k8s-minikube/kicbase:v0.0.10@sha256:f58e0c4662bac8a9b5dda7984b185bad8502ade5d9fa364bf2755d636ab51438' locally
docker: Error response from daemon: Get http://gcr.io/v2/: net/http: request canceled (Client.Timeout exceeded while awaiting headers).
See 'docker run --help'.

🤷  docker "minikube" container is missing, will recreate.
E0429 22:30:30.176700   86892 oci.go:79] docker daemon seems to be stuck. Please try restarting your docker. Will try to delete anyways: unknown state "minikube": docker inspect minikube --format={{.State.Status}}: exit status 1
stdout:


stderr:
Template parsing error: template: :1:8: executing "" at <.State.Status>: map has no entry for key "State"
🔥  Creating docker container (CPUs=2, Memory=4000MB) ...
😿  Failed to start docker container. "minikube start" may fix it: recreate: creating host: create: creating: create kic node: create container: docker run -d -t --privileged --security-opt seccomp=unconfined --security-opt apparmor=unconfined --tmpfs /tmp --tmpfs /run -v /lib/modules:/lib/modules:ro --hostname minikube --name minikube --label created_by.minikube.sigs.k8s.io=true --label name.minikube.sigs.k8s.io=minikube --label role.minikube.sigs.k8s.io= --label mode.minikube.sigs.k8s.io=minikube --volume minikube:/var --cpus=2 --memory=4000mb -e container=docker --expose 8443 --publish=127.0.0.1::8443 --publish=127.0.0.1::22 --publish=127.0.0.1::2376 --publish=127.0.0.1::5000 gcr.io/k8s-minikube/kicbase:v0.0.10@sha256:f58e0c4662bac8a9b5dda7984b185bad8502ade5d9fa364bf2755d636ab51438: exit status 125
stdout:

stderr:
Unable to find image 'gcr.io/k8s-minikube/kicbase:v0.0.10@sha256:f58e0c4662bac8a9b5dda7984b185bad8502ade5d9fa364bf2755d636ab51438' locally
docker: Error response from daemon: Get http://gcr.io/v2/: net/http: request canceled (Client.Timeout exceeded while awaiting headers).
See 'docker run --help'.


💣  error provisioning host: Failed to start host: recreate: creating host: create: creating: create kic node: create container: docker run -d -t --privileged --security-opt seccomp=unconfined --security-opt apparmor=unconfined --tmpfs /tmp --tmpfs /run -v /lib/modules:/lib/modules:ro --hostname minikube --name minikube --label created_by.minikube.sigs.k8s.io=true --label name.minikube.sigs.k8s.io=minikube --label role.minikube.sigs.k8s.io= --label mode.minikube.sigs.k8s.io=minikube --volume minikube:/var --cpus=2 --memory=4000mb -e container=docker --expose 8443 --publish=127.0.0.1::8443 --publish=127.0.0.1::22 --publish=127.0.0.1::2376 --publish=127.0.0.1::5000 gcr.io/k8s-minikube/kicbase:v0.0.10@sha256:f58e0c4662bac8a9b5dda7984b185bad8502ade5d9fa364bf2755d636ab51438: exit status 125
stdout:

stderr:
Unable to find image 'gcr.io/k8s-minikube/kicbase:v0.0.10@sha256:f58e0c4662bac8a9b5dda7984b185bad8502ade5d9fa364bf2755d636ab51438' locally
docker: Error response from daemon: Get http://gcr.io/v2/: net/http: request canceled (Client.Timeout exceeded while awaiting headers).
See 'docker run --help'.


😿  minikube is exiting due to an error. If the above message is not useful, open an issue:
👉  https://github.com/kubernetes/minikube/issues/new/choose

After this PR

$ make && ./out/minikube start --driver=docker
make: `out/minikube' is up to date.
😄  minikube v1.10.0-beta.2 on Darwin 10.15.4
✨  Using the docker driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
E0429 23:07:03.587714   94304 cache.go:130] Error downloading kic artifacts:  getting remote image: GET https://docker.pkg.github.com/v2/kubernetes/minikube/kicbase/manifests/v0.0.10: UNAUTHORIZED: GitHub Docker Registry needs login
🔥  Creating docker container (CPUs=2, Memory=4000MB) ...
🐳  Preparing Kubernetes v1.18.1 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🔎  Verifying Kubernetes components...
🌟  Enabled addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"

verifying image with docker ps

medya@~/workspace/minikube (kicbase_gh_package) $ docker ps
CONTAINER ID        IMAGE                                                       COMMAND                  CREATED             STATUS              PORTS                                                                                                      NAMES
0e0a63c61b83        docker.pkg.github.com/kubernetes/minikube/kicbase:v0.0.10   "/usr/local/bin/entr…"   46 seconds ago      Up 44 seconds       127.0.0.1:32787->22/tcp, 127.0.0.1:32786->2376/tcp, 127.0.0.1:32785->5000/tcp, 127.0.0.1:32784->8443/tcp   minikube

footnotes and not in the scope of this PR

1- github docker packages does NOT support pulling with SHA, which we consider it Acceptable but not ideal for our fallback image. ( see the note in this doc https://help.github.com/en/packages/using-github-packages-with-your-projects-ecosystem/configuring-docker-for-use-with-github-packages)

2- our go-containerregstiry lib is producing some errors about github needs login, that seems to be harmless error. (a spam error) but wont affect the functionality of using fallback. however that will be another PR to refactor our image.WriteToDaemon to not produce that error or handle it carefuly. so I will not consider to do that in this PR.

3- created another issue that we should detect early which image repo is best instead of failing one after time out and trying another one. that is also NOT in the scope of this PR.
#7942

k8s-ci-robot · 2020-04-30T06:10:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

medyagh · 2020-04-30T06:43:57Z

/ok-to-test

minikube-pr-bot · 2020-04-30T07:07:05Z

kvm2 Driver
Times for minikube: [67.81862722400001 64.49389807 69.307645336]
Average time for minikube: 67.20672354333334

Times for Minikube (PR 7943): [66.960058238 66.826738866 66.04560380000001]
Average time for Minikube (PR 7943): 66.61080030133333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7943) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.1 on   |  0.063534 |                    |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.021338 |           0.022419 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003120 |           0.003148 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.005180 |          41.933465 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.1 | 24.011590 |          22.393429 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.720292 |           1.427591 |
| components...                  |           |                    |
| * Enabled addons:              |  0.297430 |           0.684588 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.080710 |           0.076357 |
| configured to use "minikube"   |           |                    |
|                                |  0.003530 |           0.065424 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [34.337175086 26.447996072 26.373161633]
Average time for minikube: 29.052777597

Times for Minikube (PR 7943): [27.856463181000002 27.245262438 27.033811661999994]
Average time for Minikube (PR 7943): 27.378512427

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7943) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.1 on           |  0.077123 |                    |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002583 |           0.002635 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.062116 |           0.060722 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.914752 |           7.804649 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Stopping "minikube" in               |  1.111075 |                    |
| docker ...                             |           |                    |
| * Deleting "minikube" in               |  6.350240 |                    |
| docker ...                             |           |                    |
| * Creating docker container            |           |                    |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.1         |  0.122358 |           0.128847 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.420919 |          17.772293 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.884291 |           1.452899 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.002864 |           0.003299 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.074018 |           0.065201 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004648 |           0.006493 |
+----------------------------------------+-----------+--------------------+

afbjorklund · 2020-04-30T15:54:54Z

github docker packages does NOT support pulling with SHA

What was the problem with using the regular tag (instead of the digest) ?

medyagh · 2020-04-30T18:13:28Z

github docker packages does NOT support pulling with SHA

What was the problem with using the regular tag (instead of the digest) ?

that didnt work either, acording to their docs we must not use the sha. its kind of disappointing that github wouldnt allow you to pull by SHA but thats why we first pick gcr.io then fall back to github

tstromberg · 2020-04-30T20:31:02Z

pkg/minikube/node/cache.go

@@ -107,7 +108,15 @@ func beginDownloadKicArtifacts(g *errgroup.Group, driver string, cRuntime string
 			out.T(out.Pulling, "Pulling base image ...")
 			g.Go(func() error {
 				glog.Infof("Downloading %s to local daemon", baseImage)


Please add a TODO to respect --image-repository: #7915

pkg/minikube/node/cache.go

afbjorklund · 2020-05-01T07:53:26Z

that didnt work either, acording to their docs we must not use the sha.

My question was why we are not using the tag (v0.0.10) instead ?

That way it (kicbase) would work with all runtimes and all registries.

Do we plan to have multiple images per tag, or why do we need digest ?

medyagh · 2020-05-03T02:01:18Z

that didnt work either, acording to their docs we must not use the sha.

My question was why we are not using the tag (v0.0.10) instead ?

That way it (kicbase) would work with all runtimes and all registries.

Do we plan to have multiple images per tag, or why do we need digest ?

using SHA is very valuable for security and integrity, I prefer we use it whenever we can. at least for our official repo.
in this PR for all alternative repos we skip the SHA.

codecov-io · 2020-05-03T02:19:55Z

Codecov Report

Merging #7943 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7943   +/-   ##
=======================================
  Coverage   36.01%   36.01%           
=======================================
  Files         144      144           
  Lines        9207     9207           
=======================================
  Hits         3316     3316           
  Misses       5490     5490           
  Partials      401      401

minikube-pr-bot · 2020-05-04T20:37:03Z

kvm2 Driver
Times for minikube: [66.288818472 63.92113778400001 65.24262925999999]
Average time for minikube: 65.15086183866667

Times for Minikube (PR 7943): [62.59491426299999 63.378134301 64.38491705]
Average time for Minikube (PR 7943): 63.452655204666655

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7943) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on   |  0.059562 |           0.056740 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.019999 |           0.020786 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003335 |           0.003119 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 39.778084 |          40.392885 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.1 | 22.913459 |          20.766136 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.370375 |           1.414670 |
| components...                  |           |                    |
| * Enabled addons:              |  0.921576 |           0.720859 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.079852 |           0.073332 |
| configured to use "minikube"   |           |                    |
|                                |  0.004622 |           0.004128 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.932316715 26.923907296000003 25.721599067]
Average time for minikube: 26.525941025999998

Times for Minikube (PR 7943): [26.161750855 28.219286312000005 27.155855386]
Average time for Minikube (PR 7943): 27.178964184333335

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7943) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on           |  0.076764 |           0.072919 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002310 |           0.002928 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.059830 |           0.060388 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.609895 |           7.737502 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.1         |  0.120548 |           0.121298 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.668492 |          17.740184 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.798101 |           1.259743 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.125365 |           0.114012 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.060476 |           0.064289 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004161 |           0.005701 |
+----------------------------------------+-----------+--------------------+

afbjorklund · 2020-05-04T20:50:11Z

using SHA is very valuable for security and integrity, I prefer we use it whenever we can. at least for our official repo.

Problem is that the SHA is on something that we cannot verify (without the Docker registry)

The image itself doesn't know which tag/digest it will end up in, and the ID is not consistent...

So we end up having to patch every tool and library, for something that Docker doesn't support ?

minikube-pr-bot · 2020-05-04T21:06:20Z

kvm2 Driver
Times for minikube: [63.477319458 65.60381797000002 65.877826175]
Average time for minikube: 64.98632120100001

Times for Minikube (PR 7943): [62.520841604999994 63.495557346999995 64.83121233399999]
Average time for Minikube (PR 7943): 63.615870428666675

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7943) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on   |  0.059035 |           0.063835 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.019519 |           0.020650 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003186 |           0.002962 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.198342 |          40.401891 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.1 | 22.652807 |          20.915271 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.430987 |           1.333452 |
| components...                  |           |                    |
| * Enabled addons:              |  0.538667 |           0.796845 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.078872 |           0.075318 |
| configured to use "minikube"   |           |                    |
|                                |  0.004907 |           0.005648 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [28.167526651 26.919008545000004 25.681429047]
Average time for minikube: 26.922654747666666

Times for Minikube (PR 7943): [26.93760412 26.045017758 26.278521251]
Average time for Minikube (PR 7943): 26.420381043000003

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7943) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on           |  0.076957 |           0.078656 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002406 |           0.002488 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.059857 |           0.059482 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.499906 |           7.890423 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.1         |  0.147371 |           0.119831 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.043726 |          17.359746 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.855614 |           0.834266 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.168000 |           0.002482 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.063845 |           0.066112 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004971 |           0.006895 |
+----------------------------------------+-----------+--------------------+

pkg/minikube/node/cache.go

minikube-pr-bot · 2020-05-04T22:38:29Z

kvm2 Driver
Times for minikube: [68.764954753 64.18645488399999 67.35833390699999]
Average time for minikube: 66.76991451466667

Times for Minikube (PR 7943): [66.848807541 66.155819009 66.07025268699999]
Average time for Minikube (PR 7943): 66.358293079

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7943) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on   |  0.062947 |           0.064101 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.022846 |           0.023348 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003550 |           0.003151 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.121598 |          41.459922 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.1 | 23.472377 |          22.782756 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.358570 |           1.431951 |
| components...                  |           |                    |
| * Enabled addons:              |  0.624834 |           0.507933 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.099218 |           0.081043 |
| configured to use "minikube"   |           |                    |
|                                |  0.003975 |           0.004088 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.955268699999998 26.511169213 25.522817399]
Average time for minikube: 26.663085104

Times for Minikube (PR 7943): [26.745438058999998 26.204547349000002 26.970223288999996]
Average time for Minikube (PR 7943): 26.640069565666664

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7943) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on           |  0.076809 |           0.074728 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002644 |           0.002568 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.060303 |           0.060290 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.774671 |           7.635715 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.1         |  0.118412 |           0.121191 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.562836 |          17.571663 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.889715 |           1.103212 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.113067 |           0.002738 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.061812 |           0.062775 |
| configured to use "minikube"           |           |                    |
|                                        |  0.002817 |           0.005190 |
+----------------------------------------+-----------+--------------------+

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 30, 2020

k8s-ci-robot requested review from afbjorklund and sharifelgamal April 30, 2020 06:10

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2020

medyagh changed the title ~~fall back to github if gcr.io is not available~~ add alternative image repo fo kic base image Apr 30, 2020

medyagh changed the title ~~add alternative image repo fo kic base image~~ add alternative image repo (github packages) for kic base image Apr 30, 2020

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 30, 2020

kubernetes deleted a comment from minikube-pr-bot Apr 30, 2020

medyagh changed the title ~~add alternative image repo (github packages) for kic base image~~ add alternative image repo for kic base image to fallback Apr 30, 2020

tstromberg reviewed Apr 30, 2020

View reviewed changes

pkg/minikube/node/cache.go Outdated Show resolved Hide resolved

medyagh closed this May 2, 2020

medyagh deleted the kicbase_gh_package branch May 2, 2020 22:30

medyagh restored the kicbase_gh_package branch May 2, 2020 22:30

medyagh reopened this May 3, 2020

medyagh mentioned this pull request May 3, 2020

Add kic base image to the cluster config #7985

Merged

medyagh changed the title ~~add alternative image repo for kic base image to fallback~~ wip: add alternative image repo for kic base image to fallback May 3, 2020

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2020

medyagh added 2 commits May 4, 2020 13:12

fall back to github if gcr.io is not available

7914d05

add TODO with issue link

1ee8cab

medyagh force-pushed the kicbase_gh_package branch from c3a9fea to 1ee8cab Compare May 4, 2020 20:20

medyagh changed the title ~~wip: add alternative image repo for kic base image to fallback~~ add alternative image repo for kic base image to fallback May 4, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2020

address review comments

7654c1b

medyagh changed the title ~~add alternative image repo for kic base image to fallback~~ docker/podman: add alternative image repo for base image May 4, 2020

medyagh changed the title ~~docker/podman: add alternative image repo for base image~~ docker/podman: add alternative image repo for base image to fallback May 4, 2020

improve log

0189b10

tstromberg reviewed May 4, 2020

View reviewed changes

pkg/minikube/node/cache.go Show resolved Hide resolved

tstromberg approved these changes May 4, 2020

View reviewed changes

add todo comment

041a452

tstromberg approved these changes May 4, 2020

View reviewed changes

medyagh merged commit ca53537 into kubernetes:master May 4, 2020

fmotrifork mentioned this pull request May 12, 2020

minikube 1.10.0 fishworks/fish-food#725

Merged

medyagh mentioned this pull request Jun 17, 2020

pulling kic base image does not respect --image-repository or --image-mirror-country flags for CN registry mirrors #7447

Closed

medyagh deleted the kicbase_gh_package branch March 2, 2021 21:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docker/podman: add alternative image repo for base image to fallback #7943

docker/podman: add alternative image repo for base image to fallback #7943

medyagh commented Apr 30, 2020 •

edited

Loading

k8s-ci-robot commented Apr 30, 2020

medyagh commented Apr 30, 2020

minikube-pr-bot commented Apr 30, 2020

afbjorklund commented Apr 30, 2020

medyagh commented Apr 30, 2020 •

edited

Loading

tstromberg Apr 30, 2020

afbjorklund commented May 1, 2020

medyagh commented May 3, 2020

codecov-io commented May 3, 2020 •

edited

Loading

minikube-pr-bot commented May 4, 2020

afbjorklund commented May 4, 2020

minikube-pr-bot commented May 4, 2020

minikube-pr-bot commented May 4, 2020

docker/podman: add alternative image repo for base image to fallback #7943

docker/podman: add alternative image repo for base image to fallback #7943

Conversation

medyagh commented Apr 30, 2020 • edited Loading

First: Emulating not having access to GCR:

Before this PR: time out with ugly error when image not avialble

After this PR

verifying image with docker ps

footnotes and not in the scope of this PR

k8s-ci-robot commented Apr 30, 2020

medyagh commented Apr 30, 2020

minikube-pr-bot commented Apr 30, 2020

afbjorklund commented Apr 30, 2020

medyagh commented Apr 30, 2020 • edited Loading

tstromberg Apr 30, 2020

Choose a reason for hiding this comment

afbjorklund commented May 1, 2020

medyagh commented May 3, 2020

codecov-io commented May 3, 2020 • edited Loading

Codecov Report

minikube-pr-bot commented May 4, 2020

afbjorklund commented May 4, 2020

minikube-pr-bot commented May 4, 2020

minikube-pr-bot commented May 4, 2020

medyagh commented Apr 30, 2020 •

edited

Loading

medyagh commented Apr 30, 2020 •

edited

Loading

codecov-io commented May 3, 2020 •

edited

Loading