none: Skip driver preload and image caching #7015
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
Error: running mkcmp: exit status 1 |
| if !driver.IsKIC(drvName) { | ||
|
|
||
| // Preload is overly invasive for bare metal, and caching is not meaningful. | ||
| if driver.IsVM(drvName) { |
There was a problem hiding this comment.
maybe use, if !driver.BareMetal(drvName) instead
There was a problem hiding this comment.
The previous if statement excluded KIC, IsVM preserves that. Was Preload previously broken in KIC, or am I missing something?
There was a problem hiding this comment.
ah my bad, for kic we extract it differently than VM.
it would worth adding a comment with reference where we do it for kic. (in kic driver create)
This fixes this error I noticed with the none driver in our integration tests:
Historically, we avoided adding a second level of image caching for the none driver, as Docker does a fine job already. Also, none driver hosts are unlikely to have lz4, and this message does not make any sense.