Stopped and running machines should count as existing #6629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #6629 +/- ##
==========================================
+ Coverage 38.52% 38.52% +<.01%
==========================================
Files 142 142
Lines 8603 8605 +2
==========================================
+ Hits 3314 3315 +1
- Misses 4875 4876 +1
Partials 414 414
|
tstromberg
approved these changes
Feb 14, 2020
tstromberg
suggested changes
Feb 14, 2020
| @@ -199,6 +199,9 @@ func adjustGuestClock(h hostRunner, t time.Time) error { | |||
| // machineExists checks if virtual machine does not exist | |||
| // if the virtual machine exists, return true | |||
| func machineExists(d string, s state.State, err error) (bool, error) { | |||
There was a problem hiding this comment.
Maybe this should be called 'exists'?
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
All Times minikube: [ 96.846810 94.520474 93.335631] Average minikube: 94.900972 Averages Time Per Log |
medyagh
approved these changes
Feb 14, 2020
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.