Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute path, when calling the crictl command #6220

Merged
merged 3 commits into from
Jan 13, 2020

Conversation

afbjorklund
Copy link
Collaborator

Fixes #5547

We don't want the crictl or docker commands outside
To work on CentOS, which has a weird path in sudo
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2020
@afbjorklund
Copy link
Collaborator Author

Stupid unparam checker... Why would you not make it a generic function, for later ?

pkg/minikube/cruntime/cri.go:335:39: `getCommandPath` - `cmd` always receives `"crictl"` (unparam)

`getCommandPath` - `cmd` always receives `"crictl"` (unparam)
@codecov-io
Copy link

Codecov Report

Merging #6220 into master will increase coverage by 0.02%.
The diff coverage is 47.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6220      +/-   ##
==========================================
+ Coverage   38.35%   38.37%   +0.02%     
==========================================
  Files         120      120              
  Lines        8103     8117      +14     
==========================================
+ Hits         3108     3115       +7     
- Misses       4591     4597       +6     
- Partials      404      405       +1
Impacted Files Coverage Δ
pkg/minikube/cruntime/containerd.go 46.59% <0%> (ø) ⬆️
pkg/minikube/cruntime/crio.go 41.09% <0%> (ø) ⬆️
pkg/minikube/logs/logs.go 2.35% <0%> (ø) ⬆️
pkg/minikube/cruntime/cruntime.go 60% <0%> (-3.64%) ⬇️
pkg/minikube/cruntime/cri.go 57.64% <61.11%> (+0.11%) ⬆️

@medyagh
Copy link
Member

medyagh commented Jan 10, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 10, 2020
@minikube-bot
Copy link
Collaborator

All Times minikube: [ 121.034729 121.976096 121.805964]
All Times Minikube (PR 6220): [ 122.683826 123.380020 121.655048]

Average minikube: 121.605597
Average Minikube (PR 6220): 122.572964

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6220) |
+----------------------+-----------+--------------------+
| minikube v           |  0.428225 |           0.415818 |
| Creating kvm2        | 45.709772 |          45.509076 |
| Preparing Kubernetes | 50.103365 |          50.104701 |
| Pulling images       |  3.345526 |           3.074503 |
| Launching Kubernetes | 18.913565 |          20.533234 |
| Waiting for cluster  |  3.062042 |           2.894345 |
| Done                 |           |                    |
|                      |  0.044683 |           0.041286 |
+----------------------+-----------+--------------------+

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good improvement, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sudo crictl: not found if installed to a directory outside of sudoers secure_path
6 participants