-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use absolute path, when calling the crictl command #6220
Conversation
We don't want the crictl or docker commands outside
To work on CentOS, which has a weird path in sudo
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Stupid unparam checker... Why would you not make it a generic function, for later ?
|
`getCommandPath` - `cmd` always receives `"crictl"` (unparam)
Codecov Report
@@ Coverage Diff @@
## master #6220 +/- ##
==========================================
+ Coverage 38.35% 38.37% +0.02%
==========================================
Files 120 120
Lines 8103 8117 +14
==========================================
+ Hits 3108 3115 +7
- Misses 4591 4597 +6
- Partials 404 405 +1
|
/ok-to-test |
All Times minikube: [ 121.034729 121.976096 121.805964] Average minikube: 121.605597 Averages Time Per Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a good improvement, thank you
Fixes #5547