-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove retry start from integeration tests #5150
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ah ! I think I opened a canned of worm ! on the KVM TestVersionUpgrade I see the second minikube start, starts in Virtualbox !!!!
it seems like a minikube runner bug !!!
|
29de2b6
to
354855d
Compare
|
@tstromberg the TestVersionUpgrade fails consistently
that makes me believe that our pre-HEAD minikube time out was too bad and it wont make during parallel testing. Related: #5161 |
92620b8
to
9d0654f
Compare
Travis tests have failedHey @medyagh, 1st Buildmake test
TravisBuddy Request Identifier: fba1d240-c468-11e9-9094-9f1a962f5d6e |
thanks @TravisBuddy :) you are helpful ! |
Current Flakes with latest commit of this PR:
https://storage.googleapis.com/minikube-builds/logs/5150/VirtualBox_macOS.txt
--- FAIL: TestDocker (145.01s) minikube_runner.go:231: TestDocker Failed to start minikube With error: exit status 70 begin Start log block ------------> With Profile: TestDocker With Args: --docker-env=FOO=BAR --docker-env=BAZ=BAT --docker-opt=debug --docker-opt=icc=true With Global Args: --v=10 --logtostderr With Driver Args: --vm-driver=virtualbox --wait-timeout=13m --wait=false With STDOUT: * [TestDocker] minikube v1.3.1 on Debian 9.9 * Creating virtualbox VM (CPUs=2, Memory=2000MB, Disk=20000MB) ... Downloading /home/jenkins/minikube-integration/linux-amd64-virtualbox-5150-15375-7c9c4ac0f950def8ee4d4a04a369661b081478c5/.minikube/cache/boot2docker.iso from file:///home/jenkins/minikube-integration/linux-amd64-virtualbox-5150-15375-7c9c4ac0f950def8ee4d4a04a369661b081478c5/.minikube/cache/iso/minikube-v1.3.0.iso... Creating VirtualBox VM... Creating SSH key... Starting the VM... Check network to re-create if needed... Waiting for an IP... Setting Docker configuration on the remote daemon... Waiting for SSH to be available... Detecting the provisioner...
|
flake is documented here #5174 |
hopefully improve a lot of defunct process, some TestVersionUpgrade flakes