-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable registry-proxy #4341
Enable registry-proxy #4341
Conversation
As per [this blog](https://blog.hasura.io/sharing-a-local-registry-for-minikube-37c7240d0615) and [this gist](https://gist.github.com/coco98/b750b3debc6d517308596c248daf3bb1), we need to deploy a registry-proxy which will expose docker registry on the minikube host. Once this daemon set is deployed on minikube, one can access registry on `$(minikube ip):5000`. This has been tested with minikube v1.0.1 with none driver. With this, one will not have to use `kubectl port-forward`. I was able to push a container image to registry using ``` docker push $(minikube ip):5000/test-img ``` And then ran it in minikube using ``` kubectl run -i -t test-img --image=$(minikube ip):5000/test-img --restart=Never ```
Welcome @kumarom! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @kumarom. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kumarom If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you!
It looks like the CLA form is still unhappy. Does your GitHub e-mail address match the e-mail address that signed the CLA? |
/check-cla |
@tstromberg CLA form is pleased now. |
@kumarom - what's the best way to run this addon prior to it being added to the official release ? Can I download it and copy it somewhere so I can issue the |
@johnkattenhorn you could just copy this file to /etc/kubernetes/addons/registry directory on minikube VM and add-on manager will deploy this for you. |
This commit adds documentation on how to use minikube addon registry. Related to kubernetes#4341 and kubernetes#4529 Resolves kubernetes#4531 and kubernetes#4242
This commit adds documentation on how to use minikube addon registry. Related to kubernetes#4341 and kubernetes#4529 This addresses kubernetes#4531 and kubernetes#4242
As per this blog and this gist, we need to deploy a registry-proxy
which will expose docker registry on the minikube host.
Once this daemon set is deployed on minikube, one can access registry on
$(minikube ip):5000
.This has been tested with minikube v1.0.1 with none driver. With this, one will not have to use
kubectl port-forward
. I was able to push a container image to registry usingAnd then ran it in minikube using