Don't enable kubelet at boot, for consistency with other components

[marcosdiez]

I am not sure if this should be an option or not. Again, what's the use case for --vm-driver=none ?

Every other app I run in my laptop does not silently reloads upon a reboot.

I expect Minikube to behave the same.

Thinking about it, it does not do that if we use any other driver, hence this PR makes things consistent!

That's a behavior change, so if you guys want I can add a command line parameter. --dont-start-on-boot for example. (suggestions are welcome)

[k8s-ci-robot]

Hi @marcosdiez. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marcosdiez
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

If they are not already assigned, you can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[tstromberg]

/ok-to-test

Alternatively - should we ever have this enabled on boot? I'd rather remove the special case on the none driver if possible.

[tstromberg]

On second thought - yes, I think this PR would be better if it the logic was applied consistently so that we didn't enable kubelet across reboots for any drivers. VM reboots are for the time-being somewhat undefined - but my preference here is that minikube start should start kubelet in these cases.

[marcosdiez]

@tstromberg good idea! Not making the kubernetes cluster start upon reboot is a better alternative for minikube. Now my PR is a one liner!

[tstromberg]

Thanks!