-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mount: unmount on sigint/sigterm, add --options and --mode, improve UI #3855
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small nit
A refactoring of the mount command to make it suck less, inspired by @jlaswell on Slack:
--options
flag to allow arbitrary mount options to be passed--mode
flag to set the file mode of the target mountExample command:
minikube mount --mode 0777 --9p-version 9p2000 --uid 72 --gid 82 --options cache =fscache,nodevmap --msize=8192 /tmp/700:/tmp/700
Example output:
Closes #3853