Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VirtualBox time cleanup: sync on boot, don't run timesyncd #3476

Merged
merged 5 commits into from
Dec 21, 2018
Merged

VirtualBox time cleanup: sync on boot, don't run timesyncd #3476

merged 5 commits into from
Dec 21, 2018

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Dec 20, 2018 •
edited
Loading

Should resolve #2749

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 20, 2018
@tstromberg tstromberg changed the title VirtualBox time cleanup: sync on boot, don't run timesyncd, update to v5.2.22 VirtualBox time cleanup: sync on boot, don't run timesyncd Dec 20, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 20, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2018
balopat
balopat approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As VirtualBox passed - LGTM

@tstromberg tstromberg merged commit ad57efb into kubernetes:master Dec 21, 2018
@dcecile dcecile mentioned this pull request Jan 10, 2019
Closed
@reegnz reegnz mentioned this pull request Aug 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubeadm: "failure loading ca certificate: the certificate is not valid yet"
3 participants
@tstromberg @k8s-ci-robot @balopat