Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use minikube context instead of relying on current kubcetl context #2128

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Use minikube context instead of relying on current kubcetl context #2128

merged 1 commit into from
Oct 27, 2017

Conversation

mahdix
Copy link
Contributor

@mahdix mahdix commented Oct 27, 2017 •
edited
Loading

Fixes #2100

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@mahdix mahdix mentioned this pull request Oct 27, 2017
Closed
@codecov-io
Copy link

Codecov Report

Merging #2128 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2128      +/-   ##
==========================================
- Coverage   28.81%   28.78%   -0.03%     
==========================================
  Files          81       81              
  Lines        5317     5322       +5     
==========================================
  Hits         1532     1532              
- Misses       3592     3597       +5     
  Partials      193      193
Impacted Files Coverage Δ
pkg/minikube/service/service.go 29.09% <0%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69fc158...ab6e73a. Read the comment docs.

@r2d4
Copy link
Contributor

r2d4 commented Oct 27, 2017

@minikube-bot ok to test

r2d4
r2d4 approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@r2d4 r2d4 merged commit 109a23e into kubernetes:master Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r2d4 r2d4 r2d4 approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mahdix @minikube-bot @codecov-io @r2d4 @k8s-ci-robot