Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-pause: restart service after configuration #19900

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ComradeProgrammer
Copy link
Member

auto-pause: restart service after configuration

FIX #17945

After:
when the cluster is running

./out/minikube addons configure auto-pause
-- Enter interval time of auto-pause-interval (ex. 1m0s): 5s
    ▪ Using image gcr.io/k8s-minikube/auto-pause-hook:v0.0.5
✅  auto-pause was successfully configured

when the cluster is not running

./out/minikube addons configure auto-pause
-- Enter interval time of auto-pause-interval (ex. 1m0s): 8s
✅  auto-pause was successfully configured

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ComradeProgrammer
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ComradeProgrammer ComradeProgrammer removed the request for review from prezha November 1, 2024 22:24
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 1, 2024
@medyagh
Copy link
Member

medyagh commented Nov 7, 2024

@ComradeProgrammer please fix the lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix auto-pause interval value not immediately being taking affect
3 participants