-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
site: add docker.io to all echo-server examples #19395
base: master
Are you sure you want to change the base?
Conversation
Sounds like a broken cri-o configuration https://github.com/cri-o/packaging/blob/main/templates/latest/cri-o/bundle/registries.conf /etc/containers/registries.conf.d/crio.conf
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should not be needed, afaik kubernetes requires docker.io shortnames?
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
on crio not specifying the FQDN for the image name makes crio not be able to pull the image, so better to have it FQDN everywhere.
on crio
fails
$ kubectl create deployment hello-minikube --image=kicbase/echo-server:1.0
deployment.apps/hello-minikube created
works
$ kubectl create deployment hello-minikube2 --image=docker.io/kicbase/echo-server:1.0
deployment.apps/hello-minikube2 created
future works
we should consider adding docker.io to /etc/containers/registries.conf so other people dont have the same issue
#19396