rename nvidia-gpu-device-plugin to kvm-nvidia-gpu

[ilyesAj]

related to : #19114

• deprecated nvidia-gpu-device-plugin and added warning message
• Added new addon kvm-nvidia-gpu as a replacement of nvidia-gpu-device-plugin

Starting minikube with nvidia-gpu-device-plugin addon:

😄  minikube v1.33.1 on Darwin 12.6
✨  Automatically selected the docker driver. Other choices: virtualbox, ssh
📌  Using Docker Desktop driver with root privileges
👍  Starting "minikube" primary control-plane node in "minikube" cluster
🚜  Pulling base image v0.0.44-1718923403-19112 ...
💾  Downloading Kubernetes v1.30.2 preload ...
    > preloaded-images-k8s-v18-v1...:  319.86 MiB / 319.86 MiB  100.00% 30.60 M
    > index.docker.io/kicbase/bui...:  481.85 MiB / 481.85 MiB  100.00% 20.89 M



❗  minikube was unable to download gcr.io/k8s-minikube/kicbase-builds:v0.0.44-1718923403-19112, but successfully downloaded docker.io/kicbase/build:v0.0.44-1718923403-19112 as a fallback image
🔥  Creating docker container (CPUs=2, Memory=3866MB) ...
🐳  Preparing Kubernetes v1.30.2 on Docker 26.1.4 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
⌛  The nvidia-gpu-device-plugin addon is deprecated and will be removed in a future release. Please use the kvm-nvidia-gpu addon instead.for more details visit:https://github.com/kubernetes/minikube/issues/19114
🔎  Verifying Kubernetes components...
    ▪ Using image registry.k8s.io/nvidia-gpu-device-plugin
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, kvm-nvidia-gpu, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

Starting nvidia-gpu-device-plugin addon after start:

 ./out/minikube-darwin-amd64 addons enable nvidia-gpu-device-plugin                                                (27m) 17:24:38 
⌛  The nvidia-gpu-device-plugin addon is deprecated and will be removed in a future release. Please use the kvm-nvidia-gpu addon instead.for more details visit:https://github.com/kubernetes/minikube/issues/19114
❗  kvm-nvidia-gpu is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.
❗  kvm-nvidia-gpu does not currently have an associated maintainer.
    ▪ Using image registry.k8s.io/nvidia-gpu-device-plugin
🌟  The 'kvm-nvidia-gpu' addon is enabled

Starting minikube with kvm-nvidia-gpu addon:

./out/minikube-darwin-amd64 start --addons=kvm-nvidia-gpu                                                         (20m) 17:18:00 
😄  minikube v1.33.1 on Darwin 12.6
✨  Using the docker driver based on existing profile
👍  Starting "minikube" primary control-plane node in "minikube" cluster
🚜  Pulling base image v0.0.44-1718923403-19112 ...
🏃  Updating the running docker "minikube" container ...
🐳  Preparing Kubernetes v1.30.2 on Docker 26.1.4 ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
    ▪ Using image registry.k8s.io/nvidia-gpu-device-plugin
🌟  Enabled addons: kvm-nvidia-gpu, storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

Starting kvm-nvidia-gpu addon after start:

./out/minikube-darwin-amd64 addons enable kvm-nvidia-gpu                                                          (31m) 17:28:38 
❗  kvm-nvidia-gpu is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk.
❗  kvm-nvidia-gpu does not currently have an associated maintainer.
    ▪ Using image registry.k8s.io/nvidia-gpu-device-plugin
🌟  The 'kvm-nvidia-gpu' addon is enabled

[k8s-ci-robot]

Welcome @ilyesAj!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ilyesAj. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ilyesAj
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

Thanks for pick up this task,
I dont think we need to create a new Addon called KVM-nvidia...we should keep the addon intact, so we dont have to Maintain Two Copy of it.... I was hoping we have a solution that the Old Name still Works

what I had in mind was depreciation in the Flag Name, we already have an example of that

for example,

minikube start --help 
     --vm-driver='':
	DEPRECATED, use `driver` instead.

so we might have to refactor our Adddons package to allow an addon to have Two Names, or allowed it to have a depricated Name and when the user uses the depricated name we encourage them to use the new name.

and by the way this PR should probably Advice the users on the Docker Driver to use the --gpus flag instead

[ilyesAj]

@medyagh , thank you for your review, i misunderstood the need. i will try to refactor the work to:

• make both names working ( the same addon pointing on )
• deprecate the old one with just notification

for advising users on the docker driver, i double checked and it seems that on the documentation you already recommend that flag : https://minikube.sigs.k8s.io/docs/tutorials/nvidia/#docker

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[spowelljr]

Hi @ilyesAj are you still working on this?