Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump kube-vip to v0.8.0 #18774

Merged
merged 1 commit into from
May 7, 2024
Merged

bump kube-vip to v0.8.0 #18774

merged 1 commit into from
May 7, 2024

Conversation

prezha
Copy link
Contributor

@prezha prezha commented Apr 29, 2024

bumping kube-vip to v0.8.0 that was released couple of weeks ago, accommodating to the latest config

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 29, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2024
@prezha
Copy link
Contributor Author

prezha commented Apr 29, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 29, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18774) |
+----------------+----------+---------------------+
| minikube start | 50.6s    | 51.2s               |
| enable ingress | 26.8s    | 26.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.5s 27.6s 24.5s 28.2s 25.5s
Times for minikube (PR 18774) ingress: 28.5s 24.0s 24.5s 27.5s 25.5s

Times for minikube start: 49.5s 53.6s 50.7s 48.7s 50.5s
Times for minikube (PR 18774) start: 52.2s 50.1s 51.3s 50.7s 52.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18774) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 22.9s               |
| enable ingress | 21.7s    | 21.6s               |
+----------------+----------+---------------------+

Times for minikube start: 21.3s 23.7s 24.9s 23.0s 24.3s
Times for minikube (PR 18774) start: 23.5s 24.0s 20.9s 21.6s 24.4s

Times for minikube ingress: 21.3s 21.7s 21.3s 21.3s 22.8s
Times for minikube (PR 18774) ingress: 21.8s 21.3s 21.8s 21.8s 21.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18774) |
+----------------+----------+---------------------+
| minikube start | 21.5s    | 21.8s               |
| enable ingress | 32.1s    | 32.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.8s 33.2s 31.7s 31.8s 31.8s
Times for minikube (PR 18774) ingress: 30.8s 31.8s 48.3s 31.8s 17.8s

Times for minikube start: 23.2s 19.6s 22.7s 21.4s 20.6s
Times for minikube (PR 18774) start: 24.0s 22.7s 20.2s 19.2s 22.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd TestAddons/parallel/HelmTiller (gopogh) 0.00 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 0.00 (chart)
KVM_Linux_containerd TestAddons/parallel/Ingress (gopogh) 3.87 (chart)
KVM_Linux_crio TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 3.87 (chart)
Hyper-V_Windows TestPause/serial/SecondStartNoReconfiguration (gopogh) 11.39 (chart)
Hyper-V_Windows TestMultiNode/serial/DeployApp2Nodes (gopogh) 12.93 (chart)
Hyper-V_Windows TestMultiNode/serial/FreshStart2Nodes (gopogh) 12.93 (chart)
Hyper-V_Windows TestMountStart/serial/RestartStopped (gopogh) 14.43 (chart)
Hyper-V_Windows TestMultiNode/serial/AddNode (gopogh) 17.24 (chart)
Hyper-V_Windows TestMultiNode/serial/CopyFile (gopogh) 17.24 (chart)
Hyper-V_Windows TestMultiNode/serial/StopNode (gopogh) 18.10 (chart)
Hyper-V_Windows TestMultiControlPlane/serial/StopSecondaryNode (gopogh) 22.33 (chart)
Hyper-V_Windows TestKubernetesUpgrade (gopogh) 24.21 (chart)
Hyper-V_Windows TestMultiNode/serial/StartAfterStop (gopogh) 26.72 (chart)
Hyperkit_macOS TestCertOptions (gopogh) 32.35 (chart)
Hyperkit_macOS TestMultiControlPlane/serial/HAppyAfterClusterStart (gopogh) 33.66 (chart)
Hyperkit_macOS TestMultiControlPlane/serial/DeployApp (gopogh) 35.64 (chart)
Hyperkit_macOS TestMultiControlPlane/serial/PingHostFromPods (gopogh) 35.64 (chart)
Hyperkit_macOS TestMultiControlPlane/serial/StartCluster (gopogh) 36.27 (chart)
Hyperkit_macOS TestMultiControlPlane/serial/AddWorkerNode (gopogh) 39.60 (chart)

To see the flake rates of all tests by environment, click here.

medyagh
medyagh reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @prezha how about we add an automation github action job simmilar to our other update jobs, I believe you made the framework for it yourself :)

https://github.com/kubernetes/minikube/blob/master/.github/workflows/update-calico-version.yml

@prezha
Copy link
Contributor Author

prezha commented Apr 30, 2024 •
edited
Loading

thank you @prezha how about we add an automation github action job simmilar to our other update jobs, I believe you made the framework for it yourself :)

most welcome, @medyagh ! :)

true! and i did plan to eventually transition this to our automated update pr framework, just wanted to "manually" followup few releases first, as kube-vip makes some (slight) changes to the default config (we base ours off of) and once it "stabilizes" enough, we can go after automating it

spowelljr
spowelljr approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@spowelljr spowelljr merged commit 48580e8 into kubernetes:master May 7, 2024
35 of 50 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prezha, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh left review comments

@spowelljr spowelljr spowelljr approved these changes

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prezha @minikube-pr-bot @k8s-ci-robot @medyagh @spowelljr