Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addons gvisor: Add arm64 support #18063

Merged
merged 1 commit into from
Feb 29, 2024
Merged

addons gvisor: Add arm64 support #18063

merged 1 commit into from
Feb 29, 2024

Conversation

spowelljr
Copy link
Member

Adds arm64 support for gvisor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Feb 13, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 13, 2024
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@spowelljr
Copy link
Member Author

/restest-this-please

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@spowelljr
Copy link
Member Author

/restest-this-please

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18063) |
+----------------+----------+---------------------+
| minikube start | 51.0s    | 50.6s               |
| enable ingress | 24.5s    | 26.2s               |
+----------------+----------+---------------------+

Times for minikube start: 51.1s 51.3s 52.1s 49.6s 50.8s
Times for minikube (PR 18063) start: 51.2s 52.9s 48.2s 51.1s 49.3s

Times for minikube ingress: 24.1s 23.1s 27.1s 24.6s 23.6s
Times for minikube (PR 18063) ingress: 27.1s 27.7s 26.6s 26.6s 23.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18063) |
+----------------+----------+---------------------+
| minikube start | 23.7s    | 23.6s               |
| enable ingress | 21.0s    | 20.9s               |
+----------------+----------+---------------------+

Times for minikube start: 25.2s 21.9s 24.6s 25.0s 21.6s
Times for minikube (PR 18063) start: 25.1s 24.5s 24.6s 22.0s 21.8s

Times for minikube ingress: 19.8s 20.8s 21.8s 21.8s 20.8s
Times for minikube (PR 18063) ingress: 20.8s 21.3s 20.8s 20.8s 20.8s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 18063) |
+-------------------+----------+---------------------+
| minikube start    | 21.7s    | 21.9s               |
| ⚠️  enable ingress | 30.9s    | 37.3s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube ingress: 31.3s 31.3s 31.3s 30.3s 30.3s
Times for minikube (PR 18063) ingress: 46.3s 46.3s 30.3s 32.4s 31.3s

Times for minikube start: 23.4s 20.7s 20.6s 23.8s 20.2s
Times for minikube (PR 18063) start: 23.8s 23.4s 21.5s 19.8s 21.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_crio_arm64 TestFunctional/serial/ComponentHealth (gopogh) 0.00 (chart)
Docker_Linux_crio_arm64 TestFunctional/serial/ExtraConfig (gopogh) 0.00 (chart)
Hyper-V_Windows TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 0.00 (chart)
Hyper-V_Windows TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 0.00 (chart)
Hyper-V_Windows TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/AddNode (gopogh) 0.00 (chart)
Hyper-V_Windows TestMultiNode/serial/CopyFile (gopogh) 0.00 (chart)
Hyper-V_Windows TestPreload (gopogh) 0.00 (chart)
Hyper-V_Windows TestStartStop/group/default-k8s-diff-port/serial/FirstStart (gopogh) 0.00 (chart)
KVM_Linux_crio TestMountStart/serial/RestartStopped (gopogh) 0.00 (chart)
KVM_Linux TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 0.00 (chart)
KVM_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 0.62 (chart)
KVM_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 0.62 (chart)
KVM_Linux_containerd TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 0.62 (chart)
KVM_Linux_containerd TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 0.62 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 0.62 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 0.62 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 0.62 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 0.62 (chart)
KVM_Linux_containerd TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 0.62 (chart)
KVM_Linux TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 0.62 (chart)
KVM_Linux TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 0.62 (chart)
KVM_Linux TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 0.62 (chart)
KVM_Linux TestKubernetesUpgrade (gopogh) 0.62 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 0.62 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 0.62 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 0.62 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 0.62 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 0.62 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 0.62 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 5ff2939 into kubernetes:master Feb 29, 2024
32 of 50 checks passed
@spowelljr spowelljr deleted the gvisorArm64 branch February 29, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spowelljr @k8s-ci-robot @medyagh @minikube-pr-bot