-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support exposing clusterIP services via minikube service #17877
feat: support exposing clusterIP services via minikube service #17877
Conversation
Hi @ComradeProgrammer. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
9945105
to
449fb43
Compare
449fb43
to
313e97f
Compare
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 52.3s 51.5s 53.6s 51.0s 54.8s Times for minikube ingress: 27.5s 27.5s 27.2s 27.5s 27.1s docker driver with docker runtime
Times for minikube start: 24.8s 24.0s 25.6s 24.4s 23.7s Times for minikube ingress: 20.7s 21.3s 21.8s 21.3s 21.3s docker driver with containerd runtime
Times for minikube start: 20.6s 22.5s 23.0s 20.5s 23.0s Times for minikube ingress: 31.2s 47.8s 19.8s 31.8s 32.8s |
These are the flake rates of all failed tests.
Too many tests failed - See test logs for more details. To see the flake rates of all tests by environment, click here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ComradeProgrammer, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
support exposing clusterIP services via minikube service
ClusterIP cannot be visited outside the cluster, because cluster IP is a virtual private IP. However, we can visit clusterIP on one of the node of the cluster, because kube-proxy generate IPtables on these nodes for clusterIPs. This is how minikube implement port forwarding for "minikube service" on those drivers which requires port forwarding.
This time the same method is used to expose clusterIP service.
Happy New year. I am back
FIX #17283
Before:
After:
It has been tested on both Ubuntu which does not need port forward if it is a clusterIP service, and MacOS which needs it even it is not a clusterIP service.
The example yaml configuration used for this test:
P.S. Chinese translation for this part is also added