Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kubernetes version default: v1.28.3 and latest: v1.28.3 #17463

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

minikube-bot
Copy link
Collaborator

This PR was auto-generated by make update-kubernetes-version using update-k8s-versions.yml CI Workflow.
Please only merge if all the tests pass.

 M pkg/minikube/constants/constants.go
 M site/content/en/docs/commands/start.md

@minikube-bot minikube-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 23, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: minikube-bot
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17463) |
+----------------+----------+---------------------+
| minikube start | 50.9s    | 50.9s               |
| enable ingress | 27.7s    | 25.1s               |
+----------------+----------+---------------------+

Times for minikube start: 51.6s 51.2s 52.0s 47.9s 52.0s
Times for minikube (PR 17463) start: 52.3s 50.3s 48.0s 51.9s 52.2s

Times for minikube ingress: 27.1s 27.2s 27.7s 27.7s 28.7s
Times for minikube (PR 17463) ingress: 24.1s 24.1s 27.2s 26.7s 23.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17463) |
+----------------+----------+---------------------+
| minikube start | 24.0s    | 24.9s               |
| enable ingress | 20.8s    | 20.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 17463) ingress: 20.8s 20.8s 20.9s 20.9s 17.8s
Times for minikube ingress: 19.8s 19.8s 22.8s 20.9s 20.9s

Times for minikube start: 22.1s 25.2s 24.5s 22.8s 25.4s
Times for minikube (PR 17463) start: 22.8s 25.4s 24.0s 26.3s 25.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17463) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 24.7s               |
| enable ingress | 32.5s    | 37.3s               |
+----------------+----------+---------------------+

Times for minikube start: 23.8s 23.3s 23.6s 20.6s 20.4s
Times for minikube (PR 17463) start: 24.6s 24.1s 25.3s 25.1s 24.3s

Times for minikube ingress: 31.3s 31.4s 32.3s 47.3s 20.3s
Times for minikube (PR 17463) ingress: 30.3s 47.3s 30.3s 31.3s 47.3s

@medyagh medyagh merged commit 4a6cb12 into kubernetes:master Oct 23, 2023
34 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants