Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon ingress: Update ingress-nginx/controller image from v1.9.1 to v1.9.3 #17421

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

minikube-bot
Copy link
Collaborator

The ingress-nginx project released a new version

This PR was auto-generated by make update-ingress-version using update-ingress-version.yml CI Workflow.

@minikube-bot minikube-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 13, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: minikube-bot
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 13, 2023
@medyagh
Copy link
Member

medyagh commented Oct 13, 2023

/ok-to-test

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17421) |
+----------------+----------+---------------------+
| minikube start | 51.7s    | 51.2s               |
| enable ingress | 27.9s    | 27.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.2s 28.2s 28.2s 28.2s 27.6s
Times for minikube (PR 17421) ingress: 28.1s 27.7s 27.2s 28.1s 27.1s

Times for minikube start: 50.7s 53.1s 52.3s 51.9s 50.5s
Times for minikube (PR 17421) start: 50.2s 50.0s 51.3s 50.1s 54.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17421) |
+----------------+----------+---------------------+
| minikube start | 25.5s    | 24.7s               |
| enable ingress | 21.1s    | 21.4s               |
+----------------+----------+---------------------+

Times for minikube start: 25.2s 25.1s 24.9s 26.6s 25.5s
Times for minikube (PR 17421) start: 24.7s 25.5s 25.5s 22.7s 25.3s

Times for minikube ingress: 21.9s 20.9s 20.9s 20.9s 20.9s
Times for minikube (PR 17421) ingress: 20.4s 21.9s 20.9s 21.9s 21.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17421) |
+----------------+----------+---------------------+
| minikube start | 22.9s    | 23.1s               |
| enable ingress | 31.8s    | 31.8s               |
+----------------+----------+---------------------+

Times for minikube start: 21.3s 24.4s 21.1s 24.5s 23.1s
Times for minikube (PR 17421) start: 24.4s 23.3s 21.3s 23.5s 23.1s

Times for minikube ingress: 32.4s 31.4s 32.4s 31.4s 31.4s
Times for minikube (PR 17421) ingress: 31.4s 31.4s 32.4s 31.4s 32.4s

@medyagh medyagh merged commit 6bdc0f1 into kubernetes:master Oct 16, 2023
23 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants