Kicbase: Resolve docker build deprecation

[spowelljr]

Before:

docker@minikube:~$ docker build
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            Install the buildx component to build images with BuildKit:
            https://docs.docker.com/go/buildx/

"docker build" requires exactly 1 argument.
See 'docker build --help'.

Usage:  docker build [OPTIONS] PATH | URL | -

Build an image from a Dockerfile

After:

docker@minikube:~$ docker build
ERROR: "docker buildx build" requires exactly 1 argument.
See 'docker buildx build --help'.

Usage:  docker buildx build [OPTIONS] PATH | URL | -

Start a build

[spowelljr]

ok-to-build-image

[minikube-bot]

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

[spowelljr]

/ok-to-test

[medyagh]

@spowelljr
this test could be related

https://storage.googleapis.com/minikube-builds/logs/16252/28694/Hyperkit_macOS.html#fail_TestImageBuild%2fserial%2fBuildWithBuildArg

[spowelljr]

TestImageBuild/serial/BuildWithBuildArg

Yeah, I fixed the test for Kic but then I broke it for ISO. Added an if statement to do the proper thing for each

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16252) |
+----------------+----------+---------------------+
| minikube start | 54.1s    | 53.2s               |
| enable ingress | 27.8s    | 27.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 25.3s 30.8s 28.3s 28.8s 25.7s
Times for minikube (PR 16252) ingress: 34.8s 24.8s 26.3s 25.2s 25.3s

Times for minikube start: 51.0s 54.5s 54.8s 55.6s 54.4s
Times for minikube (PR 16252) start: 52.9s 54.5s 54.8s 51.2s 52.8s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 16252) |
+-------------------+----------+---------------------+
| minikube start    | 24.3s    | 24.9s               |
| ⚠️  enable ingress | 23.5s    | 33.3s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 24.3s 23.3s 24.3s 24.4s 25.4s
Times for minikube (PR 16252) start: 24.9s 24.1s 24.4s 26.1s 24.9s

Times for minikube ingress: 25.7s 27.6s 21.1s 21.1s 22.1s
Times for minikube (PR 16252) ingress: 83.6s 20.6s 22.1s 19.1s 21.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16252) |
+----------------+----------+---------------------+
| minikube start | 22.4s    | 22.8s               |
| enable ingress | 39.2s    | 30.2s               |
+----------------+----------+---------------------+

Times for minikube ingress: 47.6s 35.6s 47.6s 32.6s 32.6s
Times for minikube (PR 16252) ingress: 31.6s 32.6s 21.6s 32.6s 32.7s

Times for minikube start: 21.4s 23.6s 21.7s 22.0s 23.3s
Times for minikube (PR 16252) start: 22.9s 22.7s 23.5s 22.8s 22.2s

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Cloud_Shell	TestFunctional/parallel/UpdateContextCmd (gopogh)	n/a
Docker_Cloud_Shell	TestFunctional/parallel/CertSync (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/DashboardCmd (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/DockerEnv/bash (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/FileSync (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageBuild (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageListJson (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageListShort (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageListTable (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageRemove (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageSaveDaemon (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ImageCommands/Setup (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/InternationalLanguage (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/License (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/MountCmd/any-port (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/MountCmd/specific-port (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/MySQL (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/NodeLabels (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ProfileCmd/profile_json_output (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ProfileCmd/profile_list (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ProfileCmd/profile_not_create (gopogh)	0.00 (chart)
Docker_Cloud_Shell	TestFunctional/parallel/ServiceCmdConnect (gopogh)	0.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.