introduce the "registry" addon

[bacongobbler]

This addon installs a docker registry into kube-system and exposes it on port 80 through the service.

A separate commit was also added to add 10.0.0.0/24 to the --insecure-registry flag by default so that the kubelets can communicate with the registry addon. I tested this functionality via

$ kubectl -n kube-system get svc registry -o jsonpath="{.spec.clusterIP}"
10.0.0.240
$ minikube ssh
$ docker pull busybox
$ docker tag busybox 10.0.0.240/busybox
$ docker push 10.0.0.240/busybox

[minikube-bot]

Can one of the admins verify this patch?

[r2d4]

@minikube-bot ok to test

[bacongobbler]

I just realized that the registry replication controller contains some deployment concepts like the updateStrategy. Lemme fix that real quick

[bacongobbler]

k, fixed

[codecov-io]

Codecov Report

Merging #1583 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1583      +/-   ##
==========================================
+ Coverage    38.7%   38.78%   +0.07%     
==========================================
  Files          51       51              
  Lines        2604     2604              
==========================================
+ Hits         1008     1010       +2     
+ Misses       1418     1417       -1     
+ Partials      178      177       -1

Impacted Files	Coverage Δ
cmd/minikube/cmd/start.go	17.05% <100%> (ø)	⬆️
pkg/minikube/kubeconfig/config.go	53.33% <0%> (+1.9%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9310d...5e1db75. Read the comment docs.

[bacongobbler]

Seems like the kvm tests were flakes/unrelated issues.

[r2d4]

Yeah don't worry about those - we're working on the machines that run the linux and windows integration tests.

[r2d4]

Sorry the review took a few days - a few comments

[r2d4]

These are ran by the addon-manager so they need the appropriate labels for it
Something like:
https://github.com/kubernetes/minikube/blob/master/deploy/addons/kube-dns/kube-dns-controller.yaml#L24

[bacongobbler]

awesome. I'll update the docs on adding plugins.

[r2d4]

The addons feature has a dependency on the minikube config feature, so these need an additional entry in the list here

https://github.com/kubernetes/minikube/blob/master/cmd/minikube/cmd/config/config.go#L45-L174

Then you can enable/disable by minikube addons enable registry

[bacongobbler]

Comments addressed. Just a note that I have not been able to locally build minikube over here, so I have not been able to manually test this feature. Apologies for that!

[r2d4]

@bacongobbler why you can't build minikube locally? Maybe its something we can fix or document better.

[bacongobbler]

Hmm, I'm not sure but things are working now. Things are building locally for me!

[r2d4]

The service also needs the addon-manager label addonmanager.kubernetes.io/mode: Reconcile. Unfortunately the addon-manager will ignore any resource without this label.

[r2d4]

@bacongobbler sorry one last label needed but otherwise LGTM!

[bacongobbler]

Apologies. Thanks for catching that!

[r2d4]

Thanks! Once the workflow is finalized with draft/helm we should add some more documentation on how to use it

[georgecrawford]

Is there documentation on how to use this yet?

[r2d4]

Not yet @georgecrawford but here's a rough sketch

# enable the registry addon
$ minikube addons enable registry

$ minikube start

# use the minikube docker daemon from the host
$ eval $(minikube docker-env)

# get the ip of the registry endpoint
$ kubectl -n kube-system get svc registry -o jsonpath="{.spec.clusterIP}"
10.0.0.240

# build and push to insecure registry
$ docker build -t 10.0.0.240/busybox .
$ docker push 10.0.0.240/busybox