Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add solution message for when cri-docker is missing #14483

Merged
merged 2 commits into from
Jul 2, 2022
Merged

Add solution message for when cri-docker is missing #14483

merged 2 commits into from
Jul 2, 2022

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Jun 30, 2022 •
edited
Loading

Related: #14410

Added solution messages for when cri-docker is missing.

One message is specifically for the none driver and the other is for the rest of the drivers.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 30, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2022
@medyagh
Copy link
Member

medyagh commented Jul 1, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 1, 2022
klaases
klaases approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@klaases klaases left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klaases, medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14483) |
+----------------+----------+---------------------+
| minikube start | 56.7s    | 57.1s               |
| enable ingress | 27.6s    | 27.4s               |
+----------------+----------+---------------------+

Times for minikube start: 56.1s 55.7s 56.9s 59.7s 55.2s
Times for minikube (PR 14483) start: 57.4s 56.0s 57.1s 55.2s 59.7s

Times for minikube ingress: 25.1s 25.6s 25.5s 29.6s 32.1s
Times for minikube (PR 14483) ingress: 28.1s 28.6s 29.1s 25.5s 25.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14483) |
+----------------+----------+---------------------+
| minikube start | 28.1s    | 27.7s               |
| enable ingress | 34.2s    | 21.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 22.4s 21.5s 23.0s 81.9s 21.9s
Times for minikube (PR 14483) ingress: 21.4s 22.4s 20.9s 21.9s 21.9s

Times for minikube (PR 14483) start: 27.7s 28.2s 28.0s 27.3s 27.5s
Times for minikube start: 28.3s 27.6s 27.9s 28.3s 28.7s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14483) |
+----------------+----------+---------------------+
| minikube start | 25.9s    | 28.0s               |
| enable ingress | 26.9s    | 26.8s               |
+----------------+----------+---------------------+

Times for minikube start: 23.5s 23.7s 24.2s 23.9s 34.2s
Times for minikube (PR 14483) start: 23.0s 34.5s 23.7s 35.3s 23.6s

Times for minikube ingress: 26.5s 26.9s 27.4s 27.4s 26.4s
Times for minikube (PR 14483) ingress: 26.9s 25.9s 27.4s 26.4s 27.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestPause/serial/Pause (gopogh) 0.00 (chart)
Hyper-V_Windows TestFunctional/serial/ExtraConfig (gopogh) 0.00 (chart)
KVM_Linux TestNetworkPlugins/group/calico/Start (gopogh) 0.00 (chart)
KVM_Linux TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 4.26 (chart)
KVM_Linux TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 4.26 (chart)
KVM_Linux TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 4.26 (chart)
KVM_Linux TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 4.26 (chart)
KVM_Linux TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 4.26 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/DeployApp (gopogh) 14.29 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/FirstStart (gopogh) 14.29 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/UserAppExistsAfterStop (gopogh) 14.29 (chart)
Docker_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 15.53 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/SecondStart (gopogh) 16.46 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 20.00 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 46.75 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 46.75 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/DeployApp (gopogh) 47.44 (chart)
Docker_Linux_containerd TestStartStop/group/default-k8s-different-port/serial/FirstStart (gopogh) 48.10 (chart)
Hyper-V_Windows TestNetworkPlugins/group/kubenet/HairPin (gopogh) 48.53 (chart)
Docker_Windows TestKicCustomSubnet (gopogh) 50.00 (chart)
Docker_Windows TestMissingContainerUpgrade (gopogh) 50.00 (chart)
Docker_Windows TestNetworkPlugins/group/false/DNS (gopogh) 66.67 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 76.83 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 81.55 (chart)
Docker_Linux TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 82.52 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 85.44 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 86.41 (chart)
Docker_Linux TestNetworkPlugins/group/calico/Start (gopogh) 88.35 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithStopK8s (gopogh) 95.52 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 97.56 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 6d3a105 into kubernetes:master Jul 2, 2022
@spowelljr spowelljr deleted the criDockerSolutionMessage branch July 2, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@klaases klaases klaases approved these changes

@prezha prezha Awaiting requested review from prezha

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spowelljr @medyagh @k8s-ci-robot @minikube-pr-bot @klaases